* [PATCH] net: phy: mdio_bus: fix inverted logic in mdio_bus_match
@ 2012-12-04 17:20 Jan Luebbe
2012-12-04 21:11 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 2+ messages in thread
From: Jan Luebbe @ 2012-12-04 17:20 UTC (permalink / raw)
To: barebox
The bus match functions return 0 on success.
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
---
drivers/net/phy/mdio_bus.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 9424179..aaac559 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -126,7 +126,11 @@ static int mdio_bus_match(struct device_d *dev, struct driver_d *drv)
struct phy_device *phydev = to_phy_device(dev);
struct phy_driver *phydrv = to_phy_driver(drv);
- return ((phydrv->phy_id & phydrv->phy_id_mask) ==
+ pr_debug("%s: trying to match driver %s: (0x%08x & 0x%08x) ~ 0x%08x\n",
+ dev->name, drv->name,
+ phydev->phy_id, phydrv->phy_id_mask, phydrv->phy_id);
+
+ return ((phydrv->phy_id & phydrv->phy_id_mask) !=
(phydev->phy_id & phydrv->phy_id_mask));
}
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: phy: mdio_bus: fix inverted logic in mdio_bus_match
2012-12-04 17:20 [PATCH] net: phy: mdio_bus: fix inverted logic in mdio_bus_match Jan Luebbe
@ 2012-12-04 21:11 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 2+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-12-04 21:11 UTC (permalink / raw)
To: Jan Luebbe; +Cc: barebox
On 18:20 Tue 04 Dec , Jan Luebbe wrote:
> The bus match functions return 0 on success.
>
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
already fix in next
Best Regards,
J.
> ---
> drivers/net/phy/mdio_bus.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> index 9424179..aaac559 100644
> --- a/drivers/net/phy/mdio_bus.c
> +++ b/drivers/net/phy/mdio_bus.c
> @@ -126,7 +126,11 @@ static int mdio_bus_match(struct device_d *dev, struct driver_d *drv)
> struct phy_device *phydev = to_phy_device(dev);
> struct phy_driver *phydrv = to_phy_driver(drv);
>
> - return ((phydrv->phy_id & phydrv->phy_id_mask) ==
> + pr_debug("%s: trying to match driver %s: (0x%08x & 0x%08x) ~ 0x%08x\n",
> + dev->name, drv->name,
> + phydev->phy_id, phydrv->phy_id_mask, phydrv->phy_id);
> +
> + return ((phydrv->phy_id & phydrv->phy_id_mask) !=
> (phydev->phy_id & phydrv->phy_id_mask));
> }
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-04 21:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-04 17:20 [PATCH] net: phy: mdio_bus: fix inverted logic in mdio_bus_match Jan Luebbe
2012-12-04 21:11 ` Jean-Christophe PLAGNIOL-VILLARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox