From: Sascha Hauer <s.hauer@pengutronix.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: barebox@lists.infradead.org, jbe@pengutronix.de
Subject: Re: [PATCH] mxs: get_fecclk is hclk, not a constant
Date: Wed, 5 Dec 2012 12:41:49 +0100 [thread overview]
Message-ID: <20121205114149.GF10369@pengutronix.de> (raw)
In-Reply-To: <1354706925-13432-1-git-send-email-w.sang@pengutronix.de>
On Wed, Dec 05, 2012 at 12:28:45PM +0100, Wolfram Sang wrote:
> The rate is not constant as the comment said, but is hclk. The result
> was that MII clock was often calculated wrong.
Some more prosa would be good here:
The fec has multiple clock inputs:
- 50MHz clock for generating the (R)MII clock
- bus clock
The MDIO clock is derived from the bus clock, not the 50MHz clock,
so pass this into the driver so that it can correctly configure
the MDIO clock divider.
Sascha
>
> Reported-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> arch/arm/mach-mxs/speed-imx28.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mxs/speed-imx28.c b/arch/arm/mach-mxs/speed-imx28.c
> index df55f64..2cab42d 100644
> --- a/arch/arm/mach-mxs/speed-imx28.c
> +++ b/arch/arm/mach-mxs/speed-imx28.c
> @@ -121,8 +121,7 @@ unsigned imx_get_xtalclk(void)
>
> unsigned imx_get_fecclk(void)
> {
> - /* this PLL always runs at 50 MHz */
> - return 50000000;
> + return imx_get_hclk();
> }
>
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-12-05 11:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 11:28 Wolfram Sang
2012-12-05 11:41 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205114149.GF10369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox