[PATCH] mxs: tx28: fix NAND usage

[PATCH] mxs: tx28: fix NAND usage

[Wolfram Sang]

Pinmuxing was wrong and no GPMI device was created.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
---
 arch/arm/boards/karo-tx28/tx28.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boards/karo-tx28/tx28.c b/arch/arm/boards/karo-tx28/tx28.c
index a62cb82..6e8da15 100644
--- a/arch/arm/boards/karo-tx28/tx28.c
+++ b/arch/arm/boards/karo-tx28/tx28.c
@@ -35,11 +35,12 @@ static const uint32_t tx28_pad_setup[] = {
 	GPMI_D6 | VE_3_3V | PULLUP(1),
 	GPMI_D7 | VE_3_3V | PULLUP(1),
 	GPMI_READY0 | VE_3_3V | PULLUP(0),	/* external PU */
+	GPMI_CE0N | VE_3_3V | PULLUP(1),
 	GPMI_RDN | VE_3_3V | PULLUP(1),
 	GPMI_WRN | VE_3_3V | BITKEEPER(1),
 	GPMI_ALE | VE_3_3V | PULLUP(1),
 	GPMI_CLE | VE_3_3V | PULLUP(1),
-	GPMI_RESETN_GPIO | VE_3_3V | GPIO_IN,	/* act as WP, external PU */
+	GPMI_RESETN | VE_3_3V | PULLUP(0),	/* external PU */
 
 	/* Network interface */
 
@@ -91,6 +92,9 @@ static int tx28_devices_init(void)
 
 	base_board_init();
 
+	add_generic_device("mxs_nand", 0, NULL, MXS_GPMI_BASE, 0x2000,
+			   IORESOURCE_MEM, NULL);
+
 	return 0;
 }
 
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] mxs: tx28: fix NAND usage

[Sascha Hauer]

On Wed, Dec 05, 2012 at 03:42:42PM +0100, Wolfram Sang wrote:
> Pinmuxing was wrong and no GPMI device was created.
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>

Applied, thanks

Sascha

> ---
>  arch/arm/boards/karo-tx28/tx28.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boards/karo-tx28/tx28.c b/arch/arm/boards/karo-tx28/tx28.c
> index a62cb82..6e8da15 100644
> --- a/arch/arm/boards/karo-tx28/tx28.c
> +++ b/arch/arm/boards/karo-tx28/tx28.c
> @@ -35,11 +35,12 @@ static const uint32_t tx28_pad_setup[] = {
>  	GPMI_D6 | VE_3_3V | PULLUP(1),
>  	GPMI_D7 | VE_3_3V | PULLUP(1),
>  	GPMI_READY0 | VE_3_3V | PULLUP(0),	/* external PU */
> +	GPMI_CE0N | VE_3_3V | PULLUP(1),
>  	GPMI_RDN | VE_3_3V | PULLUP(1),
>  	GPMI_WRN | VE_3_3V | BITKEEPER(1),
>  	GPMI_ALE | VE_3_3V | PULLUP(1),
>  	GPMI_CLE | VE_3_3V | PULLUP(1),
> -	GPMI_RESETN_GPIO | VE_3_3V | GPIO_IN,	/* act as WP, external PU */
> +	GPMI_RESETN | VE_3_3V | PULLUP(0),	/* external PU */
>  
>  	/* Network interface */
>  
> @@ -91,6 +92,9 @@ static int tx28_devices_init(void)
>  
>  	base_board_init();
>  
> +	add_generic_device("mxs_nand", 0, NULL, MXS_GPMI_BASE, 0x2000,
> +			   IORESOURCE_MEM, NULL);
> +
>  	return 0;
>  }
>  
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox