mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH v2] at91: reorder BOARDINFO alphabetically
@ 2012-12-06 11:16 Fabio Porcedda
  2012-12-06 20:03 ` Sascha Hauer
  2012-12-07  6:52 ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 2 replies; 7+ messages in thread
From: Fabio Porcedda @ 2012-12-06 11:16 UTC (permalink / raw)
  To: barebox

This is to have a nicely ordered list and to decrease the
likelihood of a conflict when adding a new board.

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
v2:
 - add Cc: Jean-Christophe
 - add comment to remember the ordering

 arch/arm/mach-at91/Kconfig | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index 6fea903..a192f7c 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -6,7 +6,9 @@ config ARCH_TEXT_BASE
 	default 0x26f00000 if ARCH_AT91SAM9X5
 	default 0x23f00000
 
+# This list is sorted alphanumerically
 config BOARDINFO
+	default "Aizo dSS11" if MACH_DSS11
 	default "Atmel at91rm9200-ek" if MACH_AT91RM9200EK
 	default "Atmel at91sam9260-ek" if MACH_AT91SAM9260EK
 	default "Atmel at91sam9261-ek" if MACH_AT91SAM9261EK
@@ -17,17 +19,16 @@ config BOARDINFO
 	default "Atmel at91sam9n12-ek" if MACH_AT91SAM9N12EK
 	default "Atmel at91sam9x5-ek" if MACH_AT91SAM9X5EK
 	default "Bucyrus MMC-CPU" if MACH_MMCCPU
+	default "Calao QIL-A9260" if MACH_QIL_A9260
+	default "Calao TNY-A9260" if MACH_TNY_A9260
+	default "Calao TNY-A9263" if MACH_TNY_A9263
+	default "Calao TNY-A9G20" if MACH_TNY_A9G20
 	default "Calao USB-A9260" if MACH_USB_A9260
 	default "Calao USB-A9263" if MACH_USB_A9263
 	default "Calao USB-A9G20" if MACH_USB_A9G20
 	default "Ronetix PM9261" if MACH_PM9261
 	default "Ronetix PM9263" if MACH_PM9263
 	default "Ronetix PM9G45" if MACH_PM9G45
-	default "Aizo dSS11" if MACH_DSS11
-	default "Calao TNY-A9260" if MACH_TNY_A9260
-	default "Calao TNY-A9263" if MACH_TNY_A9263
-	default "Calao TNY-A9G20" if MACH_TNY_A9G20
-	default "Calao QIL-A9260" if MACH_QIL_A9260
 
 config HAVE_NAND_ATMEL_BUSWIDTH_16
 	bool
-- 
1.8.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] at91: reorder BOARDINFO alphabetically
  2012-12-06 11:16 [PATCH v2] at91: reorder BOARDINFO alphabetically Fabio Porcedda
@ 2012-12-06 20:03 ` Sascha Hauer
  2012-12-07  6:52 ` Jean-Christophe PLAGNIOL-VILLARD
  1 sibling, 0 replies; 7+ messages in thread
From: Sascha Hauer @ 2012-12-06 20:03 UTC (permalink / raw)
  To: Fabio Porcedda; +Cc: barebox

On Thu, Dec 06, 2012 at 12:16:43PM +0100, Fabio Porcedda wrote:
> This is to have a nicely ordered list and to decrease the
> likelihood of a conflict when adding a new board.
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

Applied, thanks

Sascha

> ---
> v2:
>  - add Cc: Jean-Christophe
>  - add comment to remember the ordering
> 
>  arch/arm/mach-at91/Kconfig | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 6fea903..a192f7c 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -6,7 +6,9 @@ config ARCH_TEXT_BASE
>  	default 0x26f00000 if ARCH_AT91SAM9X5
>  	default 0x23f00000
>  
> +# This list is sorted alphanumerically
>  config BOARDINFO
> +	default "Aizo dSS11" if MACH_DSS11
>  	default "Atmel at91rm9200-ek" if MACH_AT91RM9200EK
>  	default "Atmel at91sam9260-ek" if MACH_AT91SAM9260EK
>  	default "Atmel at91sam9261-ek" if MACH_AT91SAM9261EK
> @@ -17,17 +19,16 @@ config BOARDINFO
>  	default "Atmel at91sam9n12-ek" if MACH_AT91SAM9N12EK
>  	default "Atmel at91sam9x5-ek" if MACH_AT91SAM9X5EK
>  	default "Bucyrus MMC-CPU" if MACH_MMCCPU
> +	default "Calao QIL-A9260" if MACH_QIL_A9260
> +	default "Calao TNY-A9260" if MACH_TNY_A9260
> +	default "Calao TNY-A9263" if MACH_TNY_A9263
> +	default "Calao TNY-A9G20" if MACH_TNY_A9G20
>  	default "Calao USB-A9260" if MACH_USB_A9260
>  	default "Calao USB-A9263" if MACH_USB_A9263
>  	default "Calao USB-A9G20" if MACH_USB_A9G20
>  	default "Ronetix PM9261" if MACH_PM9261
>  	default "Ronetix PM9263" if MACH_PM9263
>  	default "Ronetix PM9G45" if MACH_PM9G45
> -	default "Aizo dSS11" if MACH_DSS11
> -	default "Calao TNY-A9260" if MACH_TNY_A9260
> -	default "Calao TNY-A9263" if MACH_TNY_A9263
> -	default "Calao TNY-A9G20" if MACH_TNY_A9G20
> -	default "Calao QIL-A9260" if MACH_QIL_A9260
>  
>  config HAVE_NAND_ATMEL_BUSWIDTH_16
>  	bool
> -- 
> 1.8.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] at91: reorder BOARDINFO alphabetically
  2012-12-06 11:16 [PATCH v2] at91: reorder BOARDINFO alphabetically Fabio Porcedda
  2012-12-06 20:03 ` Sascha Hauer
@ 2012-12-07  6:52 ` Jean-Christophe PLAGNIOL-VILLARD
  2012-12-07  8:30   ` Sascha Hauer
  1 sibling, 1 reply; 7+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-12-07  6:52 UTC (permalink / raw)
  To: Fabio Porcedda; +Cc: barebox

On 12:16 Thu 06 Dec     , Fabio Porcedda wrote:
> This is to have a nicely ordered list and to decrease the
> likelihood of a conflict when adding a new board.
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> v2:
NAK

I order them by Kconfig keepo  it that way

Best Regrds,
J.
>  - add Cc: Jean-Christophe
>  - add comment to remember the ordering
> 
>  arch/arm/mach-at91/Kconfig | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 6fea903..a192f7c 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -6,7 +6,9 @@ config ARCH_TEXT_BASE
>  	default 0x26f00000 if ARCH_AT91SAM9X5
>  	default 0x23f00000
>  
> +# This list is sorted alphanumerically
>  config BOARDINFO
> +	default "Aizo dSS11" if MACH_DSS11
>  	default "Atmel at91rm9200-ek" if MACH_AT91RM9200EK
>  	default "Atmel at91sam9260-ek" if MACH_AT91SAM9260EK
>  	default "Atmel at91sam9261-ek" if MACH_AT91SAM9261EK
> @@ -17,17 +19,16 @@ config BOARDINFO
>  	default "Atmel at91sam9n12-ek" if MACH_AT91SAM9N12EK
>  	default "Atmel at91sam9x5-ek" if MACH_AT91SAM9X5EK
>  	default "Bucyrus MMC-CPU" if MACH_MMCCPU
> +	default "Calao QIL-A9260" if MACH_QIL_A9260
> +	default "Calao TNY-A9260" if MACH_TNY_A9260
> +	default "Calao TNY-A9263" if MACH_TNY_A9263
> +	default "Calao TNY-A9G20" if MACH_TNY_A9G20
>  	default "Calao USB-A9260" if MACH_USB_A9260
>  	default "Calao USB-A9263" if MACH_USB_A9263
>  	default "Calao USB-A9G20" if MACH_USB_A9G20
>  	default "Ronetix PM9261" if MACH_PM9261
>  	default "Ronetix PM9263" if MACH_PM9263
>  	default "Ronetix PM9G45" if MACH_PM9G45
> -	default "Aizo dSS11" if MACH_DSS11
> -	default "Calao TNY-A9260" if MACH_TNY_A9260
> -	default "Calao TNY-A9263" if MACH_TNY_A9263
> -	default "Calao TNY-A9G20" if MACH_TNY_A9G20
> -	default "Calao QIL-A9260" if MACH_QIL_A9260
>  
>  config HAVE_NAND_ATMEL_BUSWIDTH_16
>  	bool
> -- 
> 1.8.0
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] at91: reorder BOARDINFO alphabetically
  2012-12-07  6:52 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2012-12-07  8:30   ` Sascha Hauer
  2012-12-07  8:49     ` Fabio Porcedda
  2012-12-07 20:06     ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 2 replies; 7+ messages in thread
From: Sascha Hauer @ 2012-12-07  8:30 UTC (permalink / raw)
  To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox

On Fri, Dec 07, 2012 at 07:52:49AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 12:16 Thu 06 Dec     , Fabio Porcedda wrote:
> > This is to have a nicely ordered list and to decrease the
> > likelihood of a conflict when adding a new board.
> > 
> > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> > Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > v2:
> NAK
> 
> I order them by Kconfig keepo  it that way

I'd say it makes more sense to keep them in the order the user actually
sees them, it makes it easier to find the entries. What's the value in
ordering them by Kconfig name?
If you order them by Kconfig name, the Calao boards end up in three
different places in the user visible view.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] at91: reorder BOARDINFO alphabetically
  2012-12-07  8:30   ` Sascha Hauer
@ 2012-12-07  8:49     ` Fabio Porcedda
  2012-12-07 20:06     ` Jean-Christophe PLAGNIOL-VILLARD
  1 sibling, 0 replies; 7+ messages in thread
From: Fabio Porcedda @ 2012-12-07  8:49 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox

On Fri, Dec 7, 2012 at 9:30 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Fri, Dec 07, 2012 at 07:52:49AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 12:16 Thu 06 Dec     , Fabio Porcedda wrote:
>> > This is to have a nicely ordered list and to decrease the
>> > likelihood of a conflict when adding a new board.
>> >
>> > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>> > Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>> > ---
>> > v2:
>> NAK
>>
>> I order them by Kconfig keepo  it that way
>
> I'd say it makes more sense to keep them in the order the user actually
> sees them, it makes it easier to find the entries. What's the value in
> ordering them by Kconfig name?
> If you order them by Kconfig name, the Calao boards end up in three
> different places in the user visible view.

IMHO it's easier and nicer to order by text, in fact the entries were not even
completely ordered by Kconfig.

--
Fabio Porcedda

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] at91: reorder BOARDINFO alphabetically
  2012-12-07  8:30   ` Sascha Hauer
  2012-12-07  8:49     ` Fabio Porcedda
@ 2012-12-07 20:06     ` Jean-Christophe PLAGNIOL-VILLARD
  2012-12-08 11:01       ` Sascha Hauer
  1 sibling, 1 reply; 7+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-12-07 20:06 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox

On 09:30 Fri 07 Dec     , Sascha Hauer wrote:
> On Fri, Dec 07, 2012 at 07:52:49AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 12:16 Thu 06 Dec     , Fabio Porcedda wrote:
> > > This is to have a nicely ordered list and to decrease the
> > > likelihood of a conflict when adding a new board.
> > > 
> > > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> > > Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > ---
> > > v2:
> > NAK
> > 
> > I order them by Kconfig keepo  it that way
> 
> I'd say it makes more sense to keep them in the order the user actually
> sees them, it makes it easier to find the entries. What's the value in
> ordering them by Kconfig name?
> If you order them by Kconfig name, the Calao boards end up in three
> different places in the user visible view.

I do it the same we do on the kernel
and I do want to keep that way the board are order by Kconfig

not by name

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] at91: reorder BOARDINFO alphabetically
  2012-12-07 20:06     ` Jean-Christophe PLAGNIOL-VILLARD
@ 2012-12-08 11:01       ` Sascha Hauer
  0 siblings, 0 replies; 7+ messages in thread
From: Sascha Hauer @ 2012-12-08 11:01 UTC (permalink / raw)
  To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox

On Fri, Dec 07, 2012 at 09:06:57PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 09:30 Fri 07 Dec     , Sascha Hauer wrote:
> > On Fri, Dec 07, 2012 at 07:52:49AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > On 12:16 Thu 06 Dec     , Fabio Porcedda wrote:
> > > > This is to have a nicely ordered list and to decrease the
> > > > likelihood of a conflict when adding a new board.
> > > > 
> > > > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> > > > Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > > ---
> > > > v2:
> > > NAK
> > > 
> > > I order them by Kconfig keepo  it that way
> > 
> > I'd say it makes more sense to keep them in the order the user actually
> > sees them, it makes it easier to find the entries. What's the value in
> > ordering them by Kconfig name?
> > If you order them by Kconfig name, the Calao boards end up in three
> > different places in the user visible view.
> 
> I do it the same we do on the kernel
> and I do want to keep that way the board are order by Kconfig

'keep' the way implies that they are ordered, they are not.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-12-08 11:02 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-06 11:16 [PATCH v2] at91: reorder BOARDINFO alphabetically Fabio Porcedda
2012-12-06 20:03 ` Sascha Hauer
2012-12-07  6:52 ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-07  8:30   ` Sascha Hauer
2012-12-07  8:49     ` Fabio Porcedda
2012-12-07 20:06     ` Jean-Christophe PLAGNIOL-VILLARD
2012-12-08 11:01       ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox