mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jan Luebbe <jlu@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM OMAP AM33XX: create new ARCH for AM33xx
Date: Wed, 12 Dec 2012 19:58:28 +0100	[thread overview]
Message-ID: <20121212185828.GY10369@pengutronix.de> (raw)
In-Reply-To: <1355223567-12671-3-git-send-email-jlu@pengutronix.de>

On Tue, Dec 11, 2012 at 11:59:27AM +0100, Jan Luebbe wrote:
> From: Teresa Gámez <t.gamez@phytec.de>
> 
> Created ARCH for AM33xx boards as second stage bootloader.
> This includes:
> - Added dmtimer0
> - Created basic header files
> - Added MMC support for ARCH_AM33XX
> - Added reset function
> 
> Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> 

[...]

> diff --git a/arch/arm/mach-omap/include/mach/clocks.h b/arch/arm/mach-omap/include/mach/clocks.h
> index 9e47a9e..ed1b368 100644
> --- a/arch/arm/mach-omap/include/mach/clocks.h
> +++ b/arch/arm/mach-omap/include/mach/clocks.h
> @@ -46,5 +46,8 @@
>  #ifdef CONFIG_ARCH_OMAP4
>  #include <mach/omap4-clock.h>
>  #endif
> +#ifdef CONFIG_ARCH_AM33XX
> +#include <mach/am33xx-clock.h>
> +#endif

We should really get rid of such things. Compiling for different SoCs by
creating conflicting defines is easy first and very painful later.
Please clean this up before more SoCs are added.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2012-12-12 18:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11 10:59 [PATCH 1/3] arm: omap: clocks: move CM_REG and PRM_REG macros Jan Luebbe
2012-12-11 10:59 ` [PATCH 2/3] arm: omap: timers: split omap3/4 timer into a separate header Jan Luebbe
2012-12-12  9:32   ` Teresa Gamez
2012-12-12 18:39   ` Sascha Hauer
2012-12-11 10:59 ` [PATCH 3/3] ARM OMAP AM33XX: create new ARCH for AM33xx Jan Luebbe
2012-12-12 18:58   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121212185828.GY10369@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=jlu@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox