Re: [PATCH 08/10] introduce common bootstrap code

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 13:51 Mon 21 Jan     , Sascha Hauer wrote:
> On Mon, Jan 21, 2013 at 12:04:16PM +0100, Alexander Aring wrote:
> > hi,
> > 
> > found a little 'things'. Maybe it's matter.
> > 
> > > +
> > > +       cdev = cdev_open(name, O_RDONLY);
> > > +       if (!cdev) {
> > > +               bootstrap_err("failed to open partition\n");
> > > +               return NULL;
> > > +       }
> > > +
> > > +       ret = cdev_read(cdev, header, BAREBOX_HEAD_SIZE, 0, 0);
> > >
> > check on error here?
> > 
> 
> This is done, see below.
> 
> > 
> > > +       cdev_close(cdev);
> > > +
> > > +       if (ret != BAREBOX_HEAD_SIZE) {
> > > +               bootstrap_err("failed to read from partition\n");
> > > +               return NULL;
> > > +       }
> > > +
> > > +       return header;
> > > +}
> > > +
> > > +
> > > +       if (!size) {
> > > +               size = default_size;
> > > +               bootstrap_err("%s: failed to detect barebox and it's image
> > > size so use %d\n",
> > > +                        devname, size);
> > > +       }
> > > +
> > > +       to = xmalloc(size);
> > >
> > check on null here?
> 
> The x versions always return memory or else they panic.

can we have this version merged

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox