mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] introduce console none support
Date: Mon, 21 Jan 2013 19:48:39 +0100	[thread overview]
Message-ID: <20130121184839.GE1906@pengutronix.de> (raw)
In-Reply-To: <1358779722-322-1-git-send-email-plagnioj@jcrosoft.com>

On Mon, Jan 21, 2013 at 03:48:42PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> this will allow to have no console support
> 
> Use full for bootstrap as we can save 900bytes (barebox.bin) and
> 500bytes (zbarebox.bin lzo) on at91sam9263 as example.
> 
> As on bootstrap we have often very limited size.
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  common/Kconfig        |    6 ++++
>  common/Makefile       |    1 +
>  common/console_none.c |   85 +++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 92 insertions(+)
>  create mode 100644 common/console_none.c
> 
> diff --git a/common/Kconfig b/common/Kconfig
> index 9d26abb..8704a42 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -506,10 +506,16 @@ config CONSOLE_ACTIVATE_NONE
>  endchoice
>  
>  config CONSOLE_SIMPLE
> +	prompt "Enable simple console support"
>  	bool
>  	default y
>  	depends on !CONSOLE_FULL
>  
> +config CONSOLE_NONE
> +	bool
> +	default y
> +	depends on !CONSOLE_FULL && !CONSOLE_SIMPLE
> +

This is probably a good moment to convert this to a choice.

> +
> +int printf (const char *fmt, ...)
> +{
> +	return 0;
> +}
> +EXPORT_SYMBOL(printf);

Have you tried providing static inline wrappers for these? I would
assume that a lot more space could be saved when gcc is able to optimize
the function calls away.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2013-01-21 18:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21 14:48 Jean-Christophe PLAGNIOL-VILLARD
2013-01-21 18:48 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130121184839.GE1906@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox