mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 8/8] memtest: add rewritten memtest command
Date: Wed, 23 Jan 2013 21:18:44 +0100	[thread overview]
Message-ID: <20130123201844.GY1906@pengutronix.de> (raw)
In-Reply-To: <20130123200134.GA3427@x61s.8.8.8.8>

Hi Alexander,

On Wed, Jan 23, 2013 at 09:01:36PM +0100, Alexander Aring wrote:
> > > +/*
> > > + * PTE flags variables to set cached and
> > > + * uncached regions.
> > > + */
> > > +static uint32_t PTE_FLAGS_CACHED;
> > > +static uint32_t PTE_FLAGS_UNCACHED;
> > 
> > Please no uppercase letters for variable names.
> >
> Ok. I took it from mach/arm/cpu/mmu.c, should I create a patch which
> rename it in arch/arm/cpu/mmu.c lower case, too?

Yes, that would be great. I must have forgotten reviewing my own patch
;)

> 
> > > +#else
> > > +static char optstr[] = "s:e:i:b";
> > > +#endif
> > > +
> > > +/*
> > > + * Perform a memory test. The complete test
> > > + * loops until interrupted by ctrl-c.
> > > + */
> > > +static int mem_test(vu_long _start, vu_long _end,
> > > +		int bus_only)
> > 
> > It would be good to move this function to common/memory_test.c. This way
> > it could be called from C. Especially testing memory might be called
> > from some early small (no shell) development binaries which are running from some
> > internal SRAM.
> > 
> Ok.
> Maybe we can do a menu entry via Kconfig or something else to run a
> memtest after booting automatically.

Maybe this could be added as an init script in the environment, but
personally I don't think I'll run it by default on our boards. We are
more into booting fast.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-01-23 20:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15 13:48 [PATCH v2 0/8] add new " Alexander Aring
2013-01-15 13:48 ` [PATCH 1/8] remap_range: make function 'remap_range' global Alexander Aring
2013-01-15 13:48 ` [PATCH 2/8] mmu: add getters for pte cache flags Alexander Aring
2013-01-15 13:48 ` [PATCH 3/8] arm-mmu: move PAGE_ALIGN macro to common.h Alexander Aring
2013-01-15 13:48 ` [PATCH 4/8] common: add PAGE_ALIGN_DOWN macro Alexander Aring
2013-01-15 13:48 ` [PATCH 5/8] memory: add function address_in_sdram_regions Alexander Aring
2013-01-15 13:48 ` [PATCH 6/8] barebox-data: add barebox-data sections Alexander Aring
2013-01-15 13:48 ` [PATCH 7/8] memtest: remove memtest command Alexander Aring
2013-01-15 13:48 ` [PATCH 8/8] memtest: add rewritten " Alexander Aring
2013-01-17  9:54   ` Sascha Hauer
2013-01-23 20:01     ` Alexander Aring
2013-01-23 20:18       ` Sascha Hauer [this message]
2013-01-23 20:25         ` Alexander Aring
2013-01-23 20:30           ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-23 20:43             ` Alexander Aring
2013-01-23 20:55               ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130123201844.GY1906@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox