From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 08/14] atmel_mci: rwproof is only needed since IP version 0x200
Date: Fri, 25 Jan 2013 18:35:35 +0100 [thread overview]
Message-ID: <20130125173535.GF26329@game.jcrosoft.org> (raw)
In-Reply-To: <20130125173119.GL1906@pengutronix.de>
On 18:31 Fri 25 Jan , Sascha Hauer wrote:
> On Fri, Jan 25, 2013 at 04:17:41PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > drivers/mci/atmel_mci.c | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mci/atmel_mci.c b/drivers/mci/atmel_mci.c
> > index d5fdd1d..bf0adb0 100644
> > --- a/drivers/mci/atmel_mci.c
> > +++ b/drivers/mci/atmel_mci.c
> > @@ -28,6 +28,7 @@
> > #include "atmel-mci-regs.h"
> >
> > struct atmel_mci_caps {
> > + bool has_rwproof;
> > bool has_odd_clk_div;
> > };
> >
> > @@ -94,7 +95,13 @@ static void atmci_set_clk_rate(struct atmel_mci *host,
> > dev_dbg(host->hw_dev, "atmel_set_clk_rate: clkIn=%ld clkIos=%d divider=%d\n",
> > host->bus_hz, clock_min, clkdiv);
> >
> > - host->mode_reg |= ATMCI_MR_RDPROOF | ATMCI_MR_WRPROOF;
> > + /*
> > + * WRPROOF and RDPROOF prevent overruns/underruns by
> > + * stopping the clock when the FIFO is full/empty.
> > + * This state is not expected to last for long.
> > + */
> > + if (host->caps.has_rwproof)
> > + host->mode_reg |= ATMCI_MR_RDPROOF | ATMCI_MR_WRPROOF;
> >
> > atmci_writel(host, ATMCI_MR, host->mode_reg);
> > }
> > @@ -470,6 +477,7 @@ static void atmci_get_cap(struct atmel_mci *host)
> > case 0x400:
> > case 0x300:
> > case 0x200:
> > + host->caps.has_rwproof = 1;
> > case 0x100:
> > case 0x0:
>
> By 'since' in the subject do you mean 'up to'?
yeah to code is right no the subject
Best Regards,
J.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-01-25 17:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 15:14 [for master PATCH 00/14] atmel_mci: fixes and cleanup Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 15:17 ` [PATCH 01/14] atmel_mci: rename atmel_mci_host tp atmel_mci Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 15:17 ` [PATCH 02/14] atmel_mci: rename atmel_mci_readl/writel to atmci_readl/writel Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 15:17 ` [PATCH 03/14] atmel_mci: rename all function to start with atmci Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 15:17 ` [PATCH 04/14] atmel_mci: use linux regs define Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 15:17 ` [PATCH 05/14] atmel_mci: detect IP version Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 15:17 ` [PATCH 06/14] atmel_mci: version 0x5xx of the IP have a different clk div Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 15:17 ` [PATCH 07/14] atmel_mci: fix host init Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 15:17 ` [PATCH 08/14] atmel_mci: rwproof is only needed since IP version 0x200 Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 17:31 ` Sascha Hauer
2013-01-25 17:35 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-01-25 15:17 ` [PATCH 09/14] atmel_mci: on version 0x0 we need to reset the IP at each request Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 15:17 ` [PATCH 10/14] atmel_mci: after a software timeout the IP need to be reset Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 15:17 ` [PATCH 11/14] atmel_mci: support the SD highspeed since IP version 0x300 Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 15:17 ` [PATCH 12/14] atmel_mci: update the SD/SDIO Card Register at request time Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 15:17 ` [PATCH 13/14] atmel_mci: drop board host caps Jean-Christophe PLAGNIOL-VILLARD
2013-01-25 15:17 ` [PATCH 14/14] atmel_mci: gpio: request and configure card detect Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125173535.GF26329@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox