From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC PATCH 1/1] omap: xload: switch to generic bootstrap
Date: Thu, 31 Jan 2013 14:20:45 +0100 [thread overview]
Message-ID: <20130131132045.GC26329@game.jcrosoft.org> (raw)
In-Reply-To: <20130130221314.GA11480@pengutronix.de>
On 23:13 Wed 30 Jan , Sascha Hauer wrote:
> On Mon, Jan 21, 2013 at 03:38:01PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > Hi,
> >
> > just compiled not tested
>
> Just tested on panda, this does not work.
>
> > +static __noreturn int omap_xload(void)
> > +{
> > + int (*func)(void) = NULL;
> > +
> > + switch (omap_bootsrc())
> > + {
>
> { should be in the previous line.
>
> > + case OMAP_BOOTSRC_MMC1:
> > + printf("booting from MMC1\n");
> > + func = bootstrap_read_disk("disk0.0", NULL);
>
> For some reason the autodetection does not work, with "fat" it works. I
> haven't investigated why. Anything else but fat does not make sense
> anyway since the OMAP ROM code expects a FAT for the MLO here and barebox
> is on the same partition.
>
> > + break;
> > + case OMAP_BOOTSRC_USB1:
> > + if (IS_ENABLED(CONFIG_FS_OMAP4_USBBOOT)) {
> > + printf("booting from USB1\n");
> > + func = bootstrap_read_disk("omap4_usbboot", "omap4_usbbootfs");
>
> 'func' is set but not used now.
it's
bootstrap_boot(func, false);
ligne 57
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-01-31 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 14:38 Jean-Christophe PLAGNIOL-VILLARD
2013-01-22 14:36 ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-30 22:13 ` Sascha Hauer
2013-01-31 13:16 ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-31 13:20 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130131132045.GC26329@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox