From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U3ZEE-0007Gf-1F for barebox@lists.infradead.org; Thu, 07 Feb 2013 21:41:58 +0000 Date: Thu, 7 Feb 2013 22:41:56 +0100 From: Sascha Hauer Message-ID: <20130207214156.GD1906@pengutronix.de> References: <1360269380-28155-1-git-send-email-alex.aring@gmail.com> <20130207213524.GC1906@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130207213524.GC1906@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 0/4] Small fixes in barebox To: Alexander Aring Cc: barebox@lists.infradead.org On Thu, Feb 07, 2013 at 10:35:24PM +0100, Sascha Hauer wrote: > On Thu, Feb 07, 2013 at 09:36:16PM +0100, Alexander Aring wrote: > > First I tried to change getopt optstring argument to "const char *" > > and I test it with an allyesconfig for compiler warnings. > > > > Then there popup some compile errors, which I tried to fix. > > > > I am not happy with some of these solutions. Maybe someone have an idea > > how we can make it better. > > > > hush: add getopt only if it enabled > > - I don't know if this needs a fix. But if we disable getopt there is a > > no-op getopt implementation in the command list. This patch don't add > > getopt to the command list at runtime, but the no-op implementation is > > still there. Maybe a compiletime solution is better to remove the > > no-op implementation. > > I don't understand. getopt is not there if CONFIG_HUSH_GETOPT is > disabled. It's ifdeffed out. Ah, now I got it. You miss the 'unknown command... message'. Then the patch seems fine. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox