From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ea0-f177.google.com ([209.85.215.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U3ZM9-00005h-V5 for barebox@lists.infradead.org; Thu, 07 Feb 2013 21:50:10 +0000 Received: by mail-ea0-f177.google.com with SMTP id n13so1281673eaa.36 for ; Thu, 07 Feb 2013 13:50:08 -0800 (PST) Date: Thu, 7 Feb 2013 22:50:54 +0100 From: Alexander Aring Message-ID: <20130207215053.GF2572@x61s.8.8.8.8> References: <1360269380-28155-1-git-send-email-alex.aring@gmail.com> <20130207213524.GC1906@pengutronix.de> <20130207214156.GD1906@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130207214156.GD1906@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 0/4] Small fixes in barebox To: Sascha Hauer Cc: barebox@lists.infradead.org Hi, On Thu, Feb 07, 2013 at 10:41:56PM +0100, Sascha Hauer wrote: > On Thu, Feb 07, 2013 at 10:35:24PM +0100, Sascha Hauer wrote: > > On Thu, Feb 07, 2013 at 09:36:16PM +0100, Alexander Aring wrote: > > > First I tried to change getopt optstring argument to "const char *" > > > and I test it with an allyesconfig for compiler warnings. > > > > > > Then there popup some compile errors, which I tried to fix. > > > > > > I am not happy with some of these solutions. Maybe someone have an idea > > > how we can make it better. > > > > > > hush: add getopt only if it enabled > > > - I don't know if this needs a fix. But if we disable getopt there is a > > > no-op getopt implementation in the command list. This patch don't add > > > getopt to the command list at runtime, but the no-op implementation is > > > still there. Maybe a compiletime solution is better to remove the > > > no-op implementation. > > > > I don't understand. getopt is not there if CONFIG_HUSH_GETOPT is > > disabled. It's ifdeffed out. > > Ah, now I got it. You miss the 'unknown command... message'. Then the > patch seems fine. > Yea, it's only a small thing... I don't know if this is necessary. :-) Maybe there is a special reason for that no error occurs. Regards Alex _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox