mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: ccmx51: Fix printing board HW-revision
@ 2013-02-08 12:28 Alexander Shiyan
  2013-02-08 12:28 ` [PATCH 2/3] ARM: ccmx51: Replace ifdefs with IS_ENABLED Alexander Shiyan
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Alexander Shiyan @ 2013-02-08 12:28 UTC (permalink / raw)
  To: barebox

Board hardware revision is 1-based. This patch corrects printed value,
so now value printed in console is equal value printed on PCB.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boards/ccxmx51/ccxmx51.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/boards/ccxmx51/ccxmx51.c b/arch/arm/boards/ccxmx51/ccxmx51.c
index a9bf16a..5ec304b 100644
--- a/arch/arm/boards/ccxmx51/ccxmx51.c
+++ b/arch/arm/boards/ccxmx51/ccxmx51.c
@@ -392,7 +392,7 @@ static int ccxmx51_devices_init(void)
 	printf("Module Variant: %s (0x%02x)\n", ccxmx51_id->id_string, hwid[0]);
 
 	if (hwid[0]) {
-		printf("Module HW Rev : %02x\n", hwid[1]);
+		printf("Module HW Rev : %02x\n", hwid[1] + 1);
 		switch (hwid[2] & 0xc0) {
 		case 0x00:
 			manloc = 'B';
-- 
1.7.3.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/3] ARM: ccmx51: Replace ifdefs with IS_ENABLED
  2013-02-08 12:28 [PATCH 1/3] ARM: ccmx51: Fix printing board HW-revision Alexander Shiyan
@ 2013-02-08 12:28 ` Alexander Shiyan
  2013-02-08 12:28 ` [PATCH 3/3] ARM: ccmx51: Add powerup delay for LAN9221 Alexander Shiyan
  2013-02-11  9:51 ` [PATCH 1/3] ARM: ccmx51: Fix printing board HW-revision Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Alexander Shiyan @ 2013-02-08 12:28 UTC (permalink / raw)
  To: barebox


Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boards/ccxmx51/ccxmx51.c |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boards/ccxmx51/ccxmx51.c b/arch/arm/boards/ccxmx51/ccxmx51.c
index 5ec304b..01e0204 100644
--- a/arch/arm/boards/ccxmx51/ccxmx51.c
+++ b/arch/arm/boards/ccxmx51/ccxmx51.c
@@ -80,12 +80,10 @@ struct imx_nand_platform_data nand_info = {
 	.flash_bbt	= 1,
 };
 
-#ifdef CONFIG_DRIVER_NET_FEC_IMX
 static struct fec_platform_data fec_info = {
 	.xcv_type	= MII100,
 	.phy_addr	= 7,
 };
-#endif
 
 static iomux_v3_cfg_t ccxmx51_pads[] = {
 	/* UART1 */
@@ -431,15 +429,12 @@ static int ccxmx51_devices_init(void)
 	devfs_add_partition("nand0", 0x80000, 0x40000, DEVFS_PARTITION_FIXED, "env_raw");
 	dev_add_bb_dev("env_raw", "env0");
 
-#ifdef CONFIG_DRIVER_NET_FEC_IMX
-	if (ccxmx51_id->eth0 && !pwr) {
+	if (IS_ENABLED(CONFIG_DRIVER_NET_FEC_IMX) && ccxmx51_id->eth0 && !pwr) {
 		eth_register_ethaddr(0, hwid);
 		imx51_add_fec(&fec_info);
 	}
-#endif
 
-#ifdef CONFIG_DRIVER_NET_SMC911X
-	if (ccxmx51_id->eth1 && !pwr) {
+	if (IS_ENABLED(CONFIG_DRIVER_NET_SMC911X) && ccxmx51_id->eth1 && !pwr) {
 		/* Configure the WEIM CS5 timming, bus width, etc */
 		/* 16 bit on DATA[31..16], not multiplexed, async */
 		writel(0x00420081, MX51_WEIM_BASE_ADDR + WEIM_CSxGCR1(5));
@@ -455,7 +450,6 @@ static int ccxmx51_devices_init(void)
 		/* LAN9221 network controller */
 		add_generic_device("smc911x", 1, NULL, MX51_CS5_BASE_ADDR, SZ_4K, IORESOURCE_MEM, NULL);
 	}
-#endif
 
 	ccxmx51_otghost_init();
 
-- 
1.7.3.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 3/3] ARM: ccmx51: Add powerup delay for LAN9221
  2013-02-08 12:28 [PATCH 1/3] ARM: ccmx51: Fix printing board HW-revision Alexander Shiyan
  2013-02-08 12:28 ` [PATCH 2/3] ARM: ccmx51: Replace ifdefs with IS_ENABLED Alexander Shiyan
@ 2013-02-08 12:28 ` Alexander Shiyan
  2013-02-11  9:51 ` [PATCH 1/3] ARM: ccmx51: Fix printing board HW-revision Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Alexander Shiyan @ 2013-02-08 12:28 UTC (permalink / raw)
  To: barebox

LAN9221 requires 50ms delay after power up. This patch adds this delay.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boards/ccxmx51/ccxmx51.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/arm/boards/ccxmx51/ccxmx51.c b/arch/arm/boards/ccxmx51/ccxmx51.c
index 01e0204..b1c579b 100644
--- a/arch/arm/boards/ccxmx51/ccxmx51.c
+++ b/arch/arm/boards/ccxmx51/ccxmx51.c
@@ -364,8 +364,10 @@ static int ccxmx51_power_init(void)
 	/* GP02 - LAN9221 Power */
 	/* GP03 - FEC Reset */
 	/* GP04 - Wireless Power */
-	if (IS_ENABLED(CONFIG_DRIVER_NET_SMC911X) && ccxmx51_id->eth1)
+	if (IS_ENABLED(CONFIG_DRIVER_NET_SMC911X) && ccxmx51_id->eth1) {
 		val |= (1 << 8);
+		mdelay(50);
+	}
 	if (IS_ENABLED(CONFIG_DRIVER_NET_FEC_IMX) && ccxmx51_id->eth0)
 		val |= (1 << 10);
 	if (ccxmx51_id->wless)
-- 
1.7.3.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] ARM: ccmx51: Fix printing board HW-revision
  2013-02-08 12:28 [PATCH 1/3] ARM: ccmx51: Fix printing board HW-revision Alexander Shiyan
  2013-02-08 12:28 ` [PATCH 2/3] ARM: ccmx51: Replace ifdefs with IS_ENABLED Alexander Shiyan
  2013-02-08 12:28 ` [PATCH 3/3] ARM: ccmx51: Add powerup delay for LAN9221 Alexander Shiyan
@ 2013-02-11  9:51 ` Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2013-02-11  9:51 UTC (permalink / raw)
  To: Alexander Shiyan; +Cc: barebox

On Fri, Feb 08, 2013 at 04:28:26PM +0400, Alexander Shiyan wrote:
> Board hardware revision is 1-based. This patch corrects printed value,
> so now value printed in console is equal value printed on PCB.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>

Applied, thanks

Sascha

> ---
>  arch/arm/boards/ccxmx51/ccxmx51.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/boards/ccxmx51/ccxmx51.c b/arch/arm/boards/ccxmx51/ccxmx51.c
> index a9bf16a..5ec304b 100644
> --- a/arch/arm/boards/ccxmx51/ccxmx51.c
> +++ b/arch/arm/boards/ccxmx51/ccxmx51.c
> @@ -392,7 +392,7 @@ static int ccxmx51_devices_init(void)
>  	printf("Module Variant: %s (0x%02x)\n", ccxmx51_id->id_string, hwid[0]);
>  
>  	if (hwid[0]) {
> -		printf("Module HW Rev : %02x\n", hwid[1]);
> +		printf("Module HW Rev : %02x\n", hwid[1] + 1);
>  		switch (hwid[2] & 0xc0) {
>  		case 0x00:
>  			manloc = 'B';
> -- 
> 1.7.3.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-02-11  9:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-08 12:28 [PATCH 1/3] ARM: ccmx51: Fix printing board HW-revision Alexander Shiyan
2013-02-08 12:28 ` [PATCH 2/3] ARM: ccmx51: Replace ifdefs with IS_ENABLED Alexander Shiyan
2013-02-08 12:28 ` [PATCH 3/3] ARM: ccmx51: Add powerup delay for LAN9221 Alexander Shiyan
2013-02-11  9:51 ` [PATCH 1/3] ARM: ccmx51: Fix printing board HW-revision Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox