From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U4rkH-00054S-9Z for barebox@lists.infradead.org; Mon, 11 Feb 2013 11:40:25 +0000 Date: Mon, 11 Feb 2013 12:40:23 +0100 From: Sascha Hauer Message-ID: <20130211114023.GB1906@pengutronix.de> References: <1360315457-30382-1-git-send-email-s.hauer@pengutronix.de> <1360315457-30382-3-git-send-email-s.hauer@pengutronix.de> <20130208110218.GA3049@x61s.8.8.8.8> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130208110218.GA3049@x61s.8.8.8.8> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/2] miitool: Add support for examing mdio bus To: Alexander Aring Cc: barebox@lists.infradead.org On Fri, Feb 08, 2013 at 12:02:20PM +0100, Alexander Aring wrote: > Hi Sascha, > > On Fri, Feb 08, 2013 at 10:24:17AM +0100, Sascha Hauer wrote: > > Current miitool usage is limited to a single phy on a mdio bus. > > > > For debugging purposes it is useful to be able to examine a mdio bus > > instead of a single phy only. > > > > This adds support for this to the miitool command. > > > > Signed-off-by: Sascha Hauer > > --- > > commands/miitool.c | 94 +++++++++++++++++++++++++++++++++++++++++----------- > > 1 file changed, 75 insertions(+), 19 deletions(-) > > > > diff --git a/commands/miitool.c b/commands/miitool.c > > index 3a9ac45..b9e2333 100644 > > --- a/commands/miitool.c > > +++ b/commands/miitool.c > > @@ -37,23 +37,36 @@ > > #include > > #include > > #include > > +#include > > > > -static u16 mdio_read(int fd, int offset) > > +static int phy_fd; > > + > > +static u16 mdio_file_read(int offset) > > { > > int ret; > > u16 buf; > > > > - ret = lseek(fd, offset << 1, SEEK_SET); > > + ret = lseek(phy_fd, offset << 1, SEEK_SET); > > if (ret < 0) > > return 0; > > > > - ret = read(fd, &buf, sizeof(u16)); > > + ret = read(phy_fd, &buf, sizeof(u16)); > > if (ret < 0) > > return 0; > > > > return buf; > > } > > I made a similar function in nandtest and I am thinking about to add a > pread and pwrite into file operations. > Is it welcome to send patches for adding pwrite and pread into file > operations? I would implement it like this but with a prototype > which looks like: > > ssize_t pread(int fildes, void *buf, size_t nbyte, off_t offset); Sounds good. Just to be sure: With 'file operations' you do not mean struct file_operations, right? > > > Another thing: > You drop the errno in this function. I don't know about the driver bus > implementation if it can return -EIO or -EBUSY. I know it's not easy to > handle it because you return the buffer. But we can change the function > like this: > > static int mdio_file_read(int offset, u16 *buf); to handle error. > > It's only a small thing that I detected. Ok, can fix this. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox