From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: barebox@lists.infradead.org, Brian Lilly <brian@crystalfontz.com>
Subject: Re: [PATCH 1/2] cfa-10036: Use the second MMC partition to store the environment
Date: Wed, 13 Feb 2013 18:12:30 +0100 [thread overview]
Message-ID: <20130213171230.GP19322@game.jcrosoft.org> (raw)
In-Reply-To: <1360773918-10663-2-git-send-email-maxime.ripard@free-electrons.com>
On 17:45 Wed 13 Feb , Maxime Ripard wrote:
> Since the only storage medium on the cfa-10036 is the MMC card, we need
> to have a registered environment partition on it if we want to be able
> to modify at runtime.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> arch/arm/boards/crystalfontz-cfa10036/cfa10036.c | 44 +++++++++++++++++++++-
> 1 file changed, 43 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c b/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c
> index b59dbab..1821b10 100644
> --- a/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c
> +++ b/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c
> @@ -97,9 +97,46 @@ static int cfa10036_mem_init(void)
> }
> mem_initcall(cfa10036_mem_init);
>
> +/**
> + * Try to register an environment storage on the attached MCI card
> + * @return 0 on success
> + *
> + * We rely on the existence of a usable SD card, already attached to
> + * our system, to get something like a persistent memory for our environment.
> + * If this SD card is also the boot media, we can use the second partition
> + * for our environment purpose (if present!).
> + */
> +static int register_persistant_environment(void)
> +{
> + struct cdev *cdev;
> +
> + /*
> + * The CFA-10036 only has one MCI card socket.
> + * So, we expect its name as "disk0".
> + */
> + cdev = cdev_by_name("disk0");
> + if (cdev == NULL) {
> + pr_err("No SD card found\n");
> + return -ENODEV;
> + }
> +
> + /* MCI card is present, also a useable partition on it? */
> + cdev = cdev_by_name("disk0.1");
> + if (cdev == NULL) {
> + pr_err("No second partition available\n");
> + pr_info("Please create at least a second partition with"
> + " 256 kiB...512 kiB in size (your choice)\n");
> + return -ENODEV;
> + }
> +
> + /* use the full partition as our persistent environment storage */
> + return devfs_add_partition("disk0.1", 0, cdev->size,
> + DEVFS_PARTITION_FIXED, "env0");
> +}
it's time to have a common code
Best Regards,
J.
> +
> static int cfa10036_devices_init(void)
> {
> - int i;
> + int i, ret;
>
> /* initizalize muxing */
> for (i = 0; i < ARRAY_SIZE(cfa10036_pads); i++)
> @@ -124,6 +161,11 @@ static int cfa10036_devices_init(void)
>
> cfa10036_detect_hw();
>
> + ret = register_persistant_environment();
> + if (ret != 0)
> + printf("Cannot create the 'env0' persistant "
> + "environment storage (%d)\n", ret);
> +
> return 0;
> }
> device_initcall(cfa10036_devices_init);
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-02-13 17:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 16:45 [PATCH 0/2] ARM: cfa10036: Store the barebox environment on the MMC Maxime Ripard
2013-02-13 16:45 ` [PATCH 1/2] cfa-10036: Use the second MMC partition to store the environment Maxime Ripard
2013-02-13 17:10 ` Eric Bénard
2013-02-13 17:12 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-02-14 9:52 ` Maxime Ripard
2013-02-14 8:16 ` Juergen Beisert
2013-02-14 10:10 ` Maxime Ripard
2013-02-14 11:17 ` Eric Bénard
2013-02-14 11:56 ` [PATCH 1/3] env: add register_persistent_environment Eric Bénard
2013-02-14 11:56 ` [PATCH 2/3] imx23-olinuxino: swith to generic peristent env Eric Bénard
2013-02-14 11:56 ` [PATCH 3/3] falconwing: switch " Eric Bénard
2013-02-14 12:09 ` Juergen Beisert
2013-02-14 13:20 ` [PATCH v2] " Eric Bénard
2013-02-14 13:50 ` [PATCH v3] " Eric Bénard
2013-02-14 19:31 ` [PATCH 1/3] env: add register_persistent_environment Sascha Hauer
2013-02-19 9:17 ` [PATCH v4 " Eric Bénard
2013-02-19 9:17 ` [PATCH v4 2/3] imx23-olinuxino: swith to generic peristent env Eric Bénard
2013-02-19 9:17 ` [PATCH v4 3/3] falconwing: switch " Eric Bénard
2013-02-19 11:58 ` [PATCH v4 1/3] env: add register_persistent_environment Jean-Christophe PLAGNIOL-VILLARD
2013-02-19 13:41 ` Eric Bénard
2013-02-19 15:35 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-19 15:49 ` Eric Bénard
2013-02-19 15:57 ` Eric Bénard
2013-02-19 19:21 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-21 6:55 ` Eric Bénard
2013-02-21 11:20 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-21 13:52 ` Sascha Hauer
2013-02-13 16:45 ` [PATCH 2/2] cfa10036: Update the environment Maxime Ripard
2013-02-26 16:50 [PATCHv2 0/2] ARM: cfa10036: Store the barebox environment on the MMC Maxime Ripard
2013-02-26 16:50 ` [PATCH 1/2] cfa-10036: Use the second MMC partition to store the environment Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213171230.GP19322@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=brian@crystalfontz.com \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox