From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH 2/5] filetype: add GPT support
Date: Thu, 14 Feb 2013 17:53:23 +0100 [thread overview]
Message-ID: <20130214165323.GU19322@game.jcrosoft.org> (raw)
In-Reply-To: <20130214163618.GV1906@pengutronix.de>
On 17:36 Thu 14 Feb , Sascha Hauer wrote:
> On Thu, Feb 14, 2013 at 04:52:24PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > GPT need to be check before MBR
> >
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > common/filetype.c | 4 ++++
> > include/filetype.h | 1 +
> > 2 files changed, 5 insertions(+)
> >
> > diff --git a/common/filetype.c b/common/filetype.c
> > index 22fc621..6563ecc 100644
> > --- a/common/filetype.c
> > +++ b/common/filetype.c
> > @@ -48,6 +48,7 @@ static const struct filetype_str filetype_str[] = {
> > [filetype_bmp] = { "BMP image", "bmp" },
> > [filetype_png] = { "PNG image", "png" },
> > [filetype_ext] = { "ext filesystem", "ext" },
> > + [filetype_gpt] = { "GUID Partition Table", "gpt" },
> > };
> >
> > const char *file_type_to_string(enum filetype f)
> > @@ -159,6 +160,9 @@ enum filetype file_detect_type(const void *_buf, size_t bufsize)
> > if (bufsize < 512)
> > return filetype_unknown;
> >
> > + if (bufsize >= 520 && strncmp(&buf8[512], "EFI PART", 8) == 0)
> > + return filetype_gpt;
> > +
>
> The list is sorted by size, so please move this below:
on purpose
EFI need to be detect before mbr
Best Regards,
J.
>
> if (bufsize < 1536)
> return filetype_unknown;
>
> Sascha
>
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-02-14 16:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 15:47 [PATCH 0/5] add EFI GUID Partition Table support Jean-Christophe PLAGNIOL-VILLARD
2013-02-14 15:52 ` [PATCH 1/5] linux/types: import __aligned_x64 from the kernel Jean-Christophe PLAGNIOL-VILLARD
2013-02-14 15:52 ` [PATCH 2/5] filetype: add GPT support Jean-Christophe PLAGNIOL-VILLARD
2013-02-14 16:36 ` Sascha Hauer
2013-02-14 16:53 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-02-14 17:05 ` Johannes Stezenbach
2013-02-14 19:17 ` Sascha Hauer
2013-02-14 22:08 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-15 7:43 ` Johannes Stezenbach
2013-02-15 10:47 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-14 15:52 ` [PATCH 3/5] partitons: add framework Jean-Christophe PLAGNIOL-VILLARD
2013-02-14 20:37 ` Sascha Hauer
2013-02-14 15:52 ` [PATCH 4/5] disk: introduce partition name Jean-Christophe PLAGNIOL-VILLARD
2013-02-14 20:51 ` Sascha Hauer
2013-02-14 21:30 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-14 21:42 ` Sascha Hauer
2013-02-14 15:52 ` [PATCH 5/5] disk: partitions: add EFI GUID Partition Table Jean-Christophe PLAGNIOL-VILLARD
2013-02-14 22:42 [PATCH 0/5] add EFI GUID Partition Table support Jean-Christophe PLAGNIOL-VILLARD
2013-02-14 22:44 ` [PATCH 1/5] linux/types: import __aligned_x64 from the kernel Jean-Christophe PLAGNIOL-VILLARD
2013-02-14 22:44 ` [PATCH 2/5] filetype: add GPT support Jean-Christophe PLAGNIOL-VILLARD
2013-02-15 7:46 ` Johannes Stezenbach
2013-02-15 9:00 ` Sascha Hauer
2013-02-15 10:45 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-15 10:56 ` Sascha Hauer
2013-02-15 12:59 [PATCH 0/5 v3] add EFI GUID Partition Table support Jean-Christophe PLAGNIOL-VILLARD
2013-02-15 13:35 ` [PATCH 1/5] linux/types: import __aligned_x64 from the kernel Jean-Christophe PLAGNIOL-VILLARD
2013-02-15 13:35 ` [PATCH 2/5] filetype: add GPT support Jean-Christophe PLAGNIOL-VILLARD
2013-02-15 17:32 ` Sascha Hauer
2013-02-15 17:36 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-15 17:48 ` Sascha Hauer
2013-02-16 11:38 [PATCH 0/5 v4] add EFI GUID Partition Table support Jean-Christophe PLAGNIOL-VILLARD
2013-02-16 13:47 ` [PATCH 1/5] linux/types: import __aligned_x64 from the kernel Jean-Christophe PLAGNIOL-VILLARD
2013-02-16 13:47 ` [PATCH 2/5] filetype: add GPT support Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130214165323.GU19322@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=rob.herring@calxeda.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox