From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Add missing SZ_xx defines
Date: Fri, 15 Feb 2013 09:51:34 +0100 [thread overview]
Message-ID: <20130215085134.GA5062@pengutronix.de> (raw)
In-Reply-To: <20130215084108.GD25672@pengutronix.de>
On Fri, Feb 15, 2013 at 09:41:08AM +0100, Sascha Hauer wrote:
> On Thu, Feb 14, 2013 at 01:59:22PM +0400, Alexander Shiyan wrote:
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> > include/sizes.h | 12 ++++++++++++
> > 1 files changed, 12 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/sizes.h b/include/sizes.h
> > index c47f906..321d40c 100644
> > --- a/include/sizes.h
> > +++ b/include/sizes.h
> > @@ -17,7 +17,19 @@
> > #define __sizes_h 1
> >
> > /* handy sizes */
> > +#define SZ_1 0x00000001
> > +#define SZ_2 0x00000002
> > +#define SZ_4 0x00000004
> > +#define SZ_8 0x00000008
> > +#define SZ_16 0x00000010
> > +#define SZ_32 0x00008020
>
> There is a tiny bug in the line above, can you find it? ;)
>
> Fixed this. Reported-by: Steffen Trumtrar, who seems to have good eyes.
>
Using Inconsolata as font helps ;-)
str
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-02-15 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 9:59 Alexander Shiyan
2013-02-14 20:22 ` Sascha Hauer
2013-02-15 8:41 ` Sascha Hauer
2013-02-15 8:43 ` Re[2]: " Alexander Shiyan
2013-02-15 8:51 ` Steffen Trumtrar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130215085134.GA5062@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox