mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] nor flash: integrate into mtd
Date: Mon, 18 Feb 2013 11:24:32 +0100	[thread overview]
Message-ID: <20130218102432.GR1906@pengutronix.de> (raw)
In-Reply-To: <20130217105856.GA949@x61s.8.8.8.8>

On Sun, Feb 17, 2013 at 11:59:14AM +0100, Alexander Aring wrote:
> Hi, 
> 
> > > diff --git a/drivers/nor/Kconfig b/drivers/mtd/nor/Kconfig
> > > similarity index 96%
> > > rename from drivers/nor/Kconfig
> > > rename to drivers/mtd/nor/Kconfig
> > > index c8ce24f..591d1ac 100644
> > > --- a/drivers/nor/Kconfig
> > > +++ b/drivers/mtd/nor/Kconfig
> > > @@ -1,7 +1,5 @@
> > > -menu "flash drivers"
> > > -
> > >  menuconfig DRIVER_CFI
> > > -	bool "CFI"
> > > +	bool "CFI NOR flash support"
> > >  	help
> > >  	  If you have NOR Flash devices connected to your system and wish
> > >  	  to use them say yes here.
> > > @@ -55,5 +53,3 @@ config CFI_BUFFER_WRITE
> > >  	depends on DRIVER_CFI || DRIVER_CFI
> 
> "DRIVER_CFI || DRIVER_CFI" looks weird. :-)
> 
> Why we not set this to depends on MTD instead of adding support for mtd
> in each config file?

Hm, this indeed looks weird. Since the Kconfig file is just moved and
not touched, I don't want to squash a fixup into it. Instead how about
the following?

8<------------------------------------------------

From ef06284cd947c4e90a54a62d2c106789c6eaebe8 Mon Sep 17 00:00:00 2001
From: Sascha Hauer <s.hauer@pengutronix.de>
Date: Mon, 18 Feb 2013 11:21:47 +0100
Subject: [PATCH] mtd nor: remove unnecessary 'depend' in Kconfig

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/mtd/nor/Kconfig |    8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/mtd/nor/Kconfig b/drivers/mtd/nor/Kconfig
index 591d1ac..44a4184 100644
--- a/drivers/mtd/nor/Kconfig
+++ b/drivers/mtd/nor/Kconfig
@@ -8,17 +8,14 @@ if DRIVER_CFI
 
 config DRIVER_CFI_INTEL
 	default y
-	depends on DRIVER_CFI
 	bool "Support Intel flash chips"
 
 config DRIVER_CFI_AMD
 	default y
-	depends on DRIVER_CFI
 	bool "support AMD flash chips"
 
 config DRIVER_CFI_BANK_WIDTH_1
 	bool "Support 8-bit buswidth"
-	depends on DRIVER_CFI
 	default y
 	help
 	  If you wish to support CFI devices on a physical bus which is
@@ -26,7 +23,6 @@ config DRIVER_CFI_BANK_WIDTH_1
 
 config DRIVER_CFI_BANK_WIDTH_2
 	bool "Support 16-bit buswidth"
-	depends on DRIVER_CFI
 	default y
 	help
 	  If you wish to support CFI devices on a physical bus which is
@@ -34,7 +30,6 @@ config DRIVER_CFI_BANK_WIDTH_2
 
 config DRIVER_CFI_BANK_WIDTH_4
 	bool "Support 32-bit buswidth"
-	depends on DRIVER_CFI
 	default y
 	help
 	  If you wish to support CFI devices on a physical bus which is
@@ -42,14 +37,11 @@ config DRIVER_CFI_BANK_WIDTH_4
 
 config DRIVER_CFI_BANK_WIDTH_8
 	bool "Support 64-bit buswidth"
-	depends on DRIVER_CFI
-	default n
 	help
 	  If you wish to support CFI devices on a physical bus which is
 	  64 bits wide, say 'Y'.
 
 config CFI_BUFFER_WRITE
 	bool "use cfi driver with buffer write"
-	depends on DRIVER_CFI || DRIVER_CFI
 
 endif
-- 
1.7.10.4


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-02-18 10:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-15  8:04 [PATCH] integrate CFI Flash driver " Sascha Hauer
2013-02-15  8:04 ` [PATCH 1/6] libmtd: rename functions from mtd_* to libmtd_* Sascha Hauer
2013-02-15  8:04 ` [PATCH 2/6] mtd: rename mtd file operations callback functions Sascha Hauer
2013-02-15  8:04 ` [PATCH 3/6] mtd: Add mtd_* functions Sascha Hauer
2013-02-15  8:04 ` [PATCH 4/6] mtd: Use mtd_* functions where appropriate Sascha Hauer
2013-02-15  8:04 ` [PATCH 5/6] mtd: implement mtd_lock and mtd_unlock Sascha Hauer
2013-02-15  8:04 ` [PATCH 6/6] nor flash: integrate into mtd Sascha Hauer
2013-02-15  8:11 ` [PATCH] " Sascha Hauer
2013-02-15  8:12   ` Sascha Hauer
2013-02-17 10:59     ` Alexander Aring
2013-02-18 10:24       ` Sascha Hauer [this message]
2013-02-19 13:23         ` Alexander Aring
2013-02-19 18:45           ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130218102432.GR1906@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox