From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] nor flash: integrate into mtd
Date: Tue, 19 Feb 2013 19:45:46 +0100 [thread overview]
Message-ID: <20130219184546.GZ1906@pengutronix.de> (raw)
In-Reply-To: <20130219132242.GA4129@x61s.8.8.8.8>
On Tue, Feb 19, 2013 at 02:23:10PM +0100, Alexander Aring wrote:
> Hi,
>
> I was thinking to add a "depends on MTD" to these drivers. But I
> detect that cfi_flashs doesn't need a MTD support.
>
> With this move we got a mtd layer in barebox, when we uses
> cfi_flash only.
>
> The cfi_flashs only uses struct mtd_info to save information about
> common flashs like erasesize, etc... and a little callback to call
> the erase function.
>
> I mean it's a good move to move this into mtd section, but will the other
> mtd functions which are not necessary not get into barebox because size
> optimiziation?
Yes, that's the downside of this patch. Unfortunately we have the
situation that UBI attaches to mtd, so the cfi flash driver was broken
for cfi flashes. We used to add a fake mtd struct especially for UBI
on nor flashes, but the recently introduced ubiformat didn't cope with
that. This patch fixes this with the cost of increasing the binary size.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-02-19 18:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 8:04 [PATCH] integrate CFI Flash driver " Sascha Hauer
2013-02-15 8:04 ` [PATCH 1/6] libmtd: rename functions from mtd_* to libmtd_* Sascha Hauer
2013-02-15 8:04 ` [PATCH 2/6] mtd: rename mtd file operations callback functions Sascha Hauer
2013-02-15 8:04 ` [PATCH 3/6] mtd: Add mtd_* functions Sascha Hauer
2013-02-15 8:04 ` [PATCH 4/6] mtd: Use mtd_* functions where appropriate Sascha Hauer
2013-02-15 8:04 ` [PATCH 5/6] mtd: implement mtd_lock and mtd_unlock Sascha Hauer
2013-02-15 8:04 ` [PATCH 6/6] nor flash: integrate into mtd Sascha Hauer
2013-02-15 8:11 ` [PATCH] " Sascha Hauer
2013-02-15 8:12 ` Sascha Hauer
2013-02-17 10:59 ` Alexander Aring
2013-02-18 10:24 ` Sascha Hauer
2013-02-19 13:23 ` Alexander Aring
2013-02-19 18:45 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219184546.GZ1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox