mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [For master PATCH 1/1] grapric_utils: set_pixel only write 16bit in 16bit mode
Date: Thu, 21 Feb 2013 15:08:55 +0100	[thread overview]
Message-ID: <20130221140855.GW1906@pengutronix.de> (raw)
In-Reply-To: <20130221140142.GD5291@game.jcrosoft.org>

On Thu, Feb 21, 2013 at 03:01:42PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 14:56 Thu 21 Feb     , Sascha Hauer wrote:
> > On Tue, Feb 19, 2013 at 10:24:14AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > ---
> > >  lib/gui/graphic_utils.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/lib/gui/graphic_utils.c b/lib/gui/graphic_utils.c
> > > index 95687df..a1be5d0 100644
> > > --- a/lib/gui/graphic_utils.c
> > > +++ b/lib/gui/graphic_utils.c
> > > @@ -104,7 +104,7 @@ void set_pixel(struct fb_info *info, void *adr, u32 px)
> > >  	case 8:
> > >  		break;
> > >  	case 16:
> > > -		*(u16 *)adr = px;
> > > +		*(u16 *)adr = px & 0xffff;
> > 
> > What does this fix? The result should be the same.
> not on qemu

Isn't this a bug in qemu?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2013-02-21 14:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19  9:24 Jean-Christophe PLAGNIOL-VILLARD
2013-02-21 13:56 ` Sascha Hauer
2013-02-21 14:01   ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-21 14:08     ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130221140855.GW1906@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox