From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U9tGu-0001Wb-Cg for barebox@lists.infradead.org; Mon, 25 Feb 2013 08:18:52 +0000 Date: Mon, 25 Feb 2013 09:18:51 +0100 From: Sascha Hauer Message-ID: <20130225081851.GP1906@pengutronix.de> References: <1361729714-8772-1-git-send-email-vicencb@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1361729714-8772-1-git-send-email-vicencb@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] OMAP4 USB BOOT: remove double line endings To: Vicente Bergas Cc: barebox@lists.infradead.org On Sun, Feb 24, 2013 at 07:15:14PM +0100, Vicente Bergas wrote: > From previous patch that replaced printf with puts: > puts adds it's own line ending, so do not append it manually > > Signed-off-by: Vicente Bergas Applied, thanks Sascha > --- > scripts/omap4_usbboot.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/scripts/omap4_usbboot.c b/scripts/omap4_usbboot.c > index 34e53c0..e521086 100644 > --- a/scripts/omap4_usbboot.c > +++ b/scripts/omap4_usbboot.c > @@ -78,7 +78,7 @@ int read_asic_id(struct usb_handle *usb) > const uint32_t msg_getid = 0xF0030003; > int i, j, k, ret; > uint8_t id[81]; > - char line[LINEWIDTH*3+8]; > + char line[LINEWIDTH*3+5]; > > printf("reading ASIC ID\n"); > memset(id , 0xee, sizeof(id)); > @@ -96,8 +96,7 @@ int read_asic_id(struct usb_handle *usb) > sprintf(line, "%02X: ", i); > for (j = 0; j < LINEWIDTH && j < sizeof(id)-i; j++) > sprintf(line+4+j*3, "%02X ", id[i+j]); > - line[4+j*3+0] = '\n'; > - line[4+j*3+1] = 0; > + line[4+j*3] = 0; > puts(line); > } > ret = 0; > -- > 1.8.1.4 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox