From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] Makefile: drop duplicate cmd_as_o_S support
Date: Tue, 26 Feb 2013 13:49:47 +0100 [thread overview]
Message-ID: <20130226124947.GE10258@game.jcrosoft.org> (raw)
In-Reply-To: <20130226100935.GI25672@pengutronix.de>
On 11:09 Tue 26 Feb , Sascha Hauer wrote:
> On Wed, Feb 20, 2013 at 03:25:15PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > as we have it to in scripts/Makefile.lib
> >
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > Makefile | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index a27c07a..7f97e8f 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1210,14 +1210,6 @@ quiet_cmd_rmdirs = $(if $(wildcard $(rm-dirs)),CLEAN $(wildcard $(rm-dirs)))
> > quiet_cmd_rmfiles = $(if $(wildcard $(rm-files)),CLEAN $(wildcard $(rm-files)))
> > cmd_rmfiles = rm -f $(rm-files)
> >
> > -
> > -a_flags = -Wp,-MD,$(depfile) $(AFLAGS) $(AFLAGS_KERNEL) \
> > - $(NOSTDINC_FLAGS) $(CPPFLAGS) \
> > - $(modkern_aflags) $(EXTRA_AFLAGS) $(AFLAGS_$(basetarget).o)
> > -
> > -quiet_cmd_as_o_S = AS $@
> > -cmd_as_o_S = $(CC) $(a_flags) -c -o $@ $<
> > -
> > # read all saved command lines
>
> I dropped this one as it breaks compilation in a number of defconfigs:
>
> cupid_defconfig:
> /bin/sh: 1: Syntax error: ";" unexpected
> make: *** [.tmp_kallsyms1.o] Error 2
I found the as_o_S is in Makefile.build not .lib
so not alwaysed included do not known why
this should be
>
> I haven't investigated the reasons.
Best Regards,
J.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-02-26 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 14:25 Jean-Christophe PLAGNIOL-VILLARD
2013-02-21 13:45 ` Sascha Hauer
2013-02-26 10:09 ` Sascha Hauer
2013-02-26 12:49 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130226124947.GE10258@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox