From: Sascha Hauer <s.hauer@pengutronix.de>
To: Fabio Porcedda <fabio.porcedda@gmail.com>
Cc: barebox@lists.infradead.org, Vicente Bergas <vicencb@gmail.com>
Subject: Re: [PATCH v2] menu: fix remove superfluous newline: change puts() -> printf("%s", )
Date: Tue, 26 Feb 2013 15:04:42 +0100 [thread overview]
Message-ID: <20130226140442.GW1906@pengutronix.de> (raw)
In-Reply-To: <1361810808-6288-1-git-send-email-fabio.porcedda@gmail.com>
On Mon, Feb 25, 2013 at 05:46:48PM +0100, Fabio Porcedda wrote:
> Fix previous commit:
> 638f91b "fix compiler warnings: use puts() instead of printf()".
>
> Because puts() function add a newline, use instead printf("%s", ).
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: Vicente Bergas <vicencb@gmail.com>
Applied, thanks
Sascha
> ---
>
> Notes:
> v2:
> - corrected two typos in the description
>
> common/menu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/menu.c b/common/menu.c
> index 30dced7..a672e59 100644
> --- a/common/menu.c
> +++ b/common/menu.c
> @@ -274,7 +274,7 @@ int menu_show(struct menu *m)
> printf("Auto Select in");
> } else {
> auto_display_len = strlen(m->auto_display);
> - puts(m->auto_display);
> + printf("%s", m->auto_display);
> }
> printf(" %2d", countdown--);
> }
> --
> 1.8.1.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-02-26 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 16:46 Fabio Porcedda
2013-02-26 14:04 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130226140442.GW1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=fabio.porcedda@gmail.com \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox