mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] usb: ehci: initialize ehci_data
Date: Mon, 4 Mar 2013 20:25:49 +0100	[thread overview]
Message-ID: <20130304192548.GB911@x61s.8.8.8.8> (raw)
In-Reply-To: <20130304191617.GG1906@pengutronix.de>

On Mon, Mar 04, 2013 at 08:16:17PM +0100, Sascha Hauer wrote:
> On Mon, Mar 04, 2013 at 08:05:29PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 17:00 Mon 04 Mar     , Sascha Hauer wrote:
> > > Without it fields of ehci_data may be unitialized and the driver
> > > crashes.
> > > 
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > ---
> > >  drivers/usb/host/ehci-hcd.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> > > index 0c789e4..7c389aa 100644
> > > --- a/drivers/usb/host/ehci-hcd.c
> > > +++ b/drivers/usb/host/ehci-hcd.c
> > > @@ -892,7 +892,7 @@ int ehci_register(struct device_d *dev, struct ehci_data *data)
> > >  
> > >  static int ehci_probe(struct device_d *dev)
> > >  {
> > > -	struct ehci_data data;
> > > +	struct ehci_data data = {};
> > 
> > I'll prefer a memset
> 
> Then you'll happy to hear that this is what the compiler makes from it
> anyway.
>
I think memset use a unnecessary function call. Is that right?

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-03-04 19:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 16:00 Sascha Hauer
2013-03-04 19:05 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-04 19:16   ` Sascha Hauer
2013-03-04 19:25     ` Alexander Aring [this message]
2013-03-04 19:28       ` Sascha Hauer
2013-03-04 19:32         ` Alexander Aring
2013-03-08  5:57 ` Antony Pavlov
2013-03-08  7:24   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130304192548.GB911@x61s.8.8.8.8 \
    --to=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox