mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/6] ARM: make cpu architecture detection available as static inline function
Date: Mon, 4 Mar 2013 21:46:56 +0100	[thread overview]
Message-ID: <20130304204656.GD911@x61s.8.8.8.8> (raw)
In-Reply-To: <1362427389-2144-2-git-send-email-s.hauer@pengutronix.de>

Hi,

On Mon, Mar 04, 2013 at 09:03:04PM +0100, Sascha Hauer wrote:
> When we have multi cpu support compiled in we need the cpu architecture
> early so that we can pick the correct cacheflush function. Make it available
> as static inline function and add a comment above it that this function
> normally should not be used.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  arch/arm/cpu/cpu.c                 | 34 +-----------------------------
>  arch/arm/include/asm/system_info.h | 43 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 44 insertions(+), 33 deletions(-)
> 
> diff --git a/arch/arm/cpu/cpu.c b/arch/arm/cpu/cpu.c
> index 5f697d7..f2e698d 100644
> --- a/arch/arm/cpu/cpu.c
> +++ b/arch/arm/cpu/cpu.c
> @@ -148,45 +148,13 @@ postcore_initcall(execute_init);
>  #endif
>  
>  #ifdef ARM_MULTIARCH
> -static int __get_cpu_architecture(void)
> -{
> -	int cpu_arch;
> -
> -	if ((read_cpuid_id() & 0x0008f000) == 0) {
> -		cpu_arch = CPU_ARCH_UNKNOWN;
> -	} else if ((read_cpuid_id() & 0x0008f000) == 0x00007000) {
> -		cpu_arch = (read_cpuid_id() & (1 << 23)) ? CPU_ARCH_ARMv4T : CPU_ARCH_ARMv3;
> -	} else if ((read_cpuid_id() & 0x00080000) == 0x00000000) {
> -		cpu_arch = (read_cpuid_id() >> 16) & 7;
> -		if (cpu_arch)
> -			cpu_arch += CPU_ARCH_ARMv3;
> -	} else if ((read_cpuid_id() & 0x000f0000) == 0x000f0000) {
> -		unsigned int mmfr0;
> -
> -		/* Revised CPUID format. Read the Memory Model Feature
> -		 * Register 0 and check for VMSAv7 or PMSAv7 */
> -		asm("mrc	p15, 0, %0, c0, c1, 4"
> -		    : "=r" (mmfr0));
> -		if ((mmfr0 & 0x0000000f) >= 0x00000003 ||
> -		    (mmfr0 & 0x000000f0) >= 0x00000030)
> -			cpu_arch = CPU_ARCH_ARMv7;
> -		else if ((mmfr0 & 0x0000000f) == 0x00000002 ||
> -			 (mmfr0 & 0x000000f0) == 0x00000020)
> -			cpu_arch = CPU_ARCH_ARMv6;
> -		else
> -			cpu_arch = CPU_ARCH_UNKNOWN;
> -	} else
> -		cpu_arch = CPU_ARCH_UNKNOWN;
> -
> -	return cpu_arch;
> -}
>  
>  int __cpu_architecture;
>  
>  int __pure cpu_architecture(void)
>  {
>  	if(__cpu_architecture == CPU_ARCH_UNKNOWN)
> -		__cpu_architecture = __get_cpu_architecture();
> +		__cpu_architecture = arm_early_get_cpu_architecture();
>  
>  	return __cpu_architecture;
>  }
> diff --git a/arch/arm/include/asm/system_info.h b/arch/arm/include/asm/system_info.h
> index 56ebb11..50769ec 100644
> --- a/arch/arm/include/asm/system_info.h
> +++ b/arch/arm/include/asm/system_info.h
> @@ -110,8 +110,51 @@
>  #ifndef __ASSEMBLY__
>  
>  #ifdef ARM_MULTIARCH
> +/*
> + * Early version to get the ARM cpu architecture. Only needed during
> + * early startup when the C environment is not yet fully initialized.
> + * Normally you should use cpu_architecture() instead.
> + */
> +static inline int arm_early_get_cpu_architecture(void)
> +{
> +	int cpu_arch;
> +
> +	if ((read_cpuid_id() & 0x0008f000) == 0) {
> +		cpu_arch = CPU_ARCH_UNKNOWN;
> +	} else if ((read_cpuid_id() & 0x0008f000) == 0x00007000) {
> +		cpu_arch = (read_cpuid_id() & (1 << 23)) ? CPU_ARCH_ARMv4T : CPU_ARCH_ARMv3;
> +	} else if ((read_cpuid_id() & 0x00080000) == 0x00000000) {
> +		cpu_arch = (read_cpuid_id() >> 16) & 7;
> +		if (cpu_arch)
> +			cpu_arch += CPU_ARCH_ARMv3;

I know... it's only a movement, but is cpu += CPU_ARCH_ARMv3 correct
here? All other has only a assignment.

> +	} else if ((read_cpuid_id() & 0x000f0000) == 0x000f0000) {
> +		unsigned int mmfr0;
> +
> +		/* Revised CPUID format. Read the Memory Model Feature
> +		 * Register 0 and check for VMSAv7 or PMSAv7 */
> +		asm("mrc	p15, 0, %0, c0, c1, 4"
> +		    : "=r" (mmfr0));
> +		if ((mmfr0 & 0x0000000f) >= 0x00000003 ||
> +		    (mmfr0 & 0x000000f0) >= 0x00000030)
> +			cpu_arch = CPU_ARCH_ARMv7;
> +		else if ((mmfr0 & 0x0000000f) == 0x00000002 ||
> +			 (mmfr0 & 0x000000f0) == 0x00000020)
> +			cpu_arch = CPU_ARCH_ARMv6;
> +		else
> +			cpu_arch = CPU_ARCH_UNKNOWN;
> +	} else
> +		cpu_arch = CPU_ARCH_UNKNOWN;
> +
> +	return cpu_arch;
> +}
> +
>  extern int __pure cpu_architecture(void);
>  #else
> +static inline int __pure arm_early_get_cpu_architecture(void)
> +{
> +	return ARM_ARCH;
> +}
> +
>  static inline int __pure cpu_architecture(void)
>  {
>  	return ARM_ARCH;
> -- 
> 1.8.2.rc2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-03-04 20:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 20:03 [PATCH] ARM: Add relocatable binary support Sascha Hauer
2013-03-04 20:03 ` [PATCH 1/6] ARM: make cpu architecture detection available as static inline function Sascha Hauer
2013-03-04 20:46   ` Alexander Aring [this message]
2013-03-05 10:34     ` Sascha Hauer
2013-03-04 20:03 ` [PATCH 2/6] ARM: add early mmu cache flush function and use it in setup_c Sascha Hauer
2013-03-04 20:03 ` [PATCH 3/6] ARM: provide accessor functions for linker variables Sascha Hauer
2013-03-04 20:03 ` [PATCH 4/6] ARM boards: Use accessor functions to access " Sascha Hauer
2013-03-04 20:03 ` [PATCH 5/6] ARN: fixup vector addresses for relocatable binaries Sascha Hauer
2013-03-04 20:03 ` [PATCH 6/6] ARM: Add relocatable binary support Sascha Hauer
2013-03-04 20:10   ` Alexander Shiyan
2013-03-04 20:19     ` Sascha Hauer
2013-03-05  4:32       ` Re[2]: " Alexander Shiyan
2013-03-05  7:25         ` Sascha Hauer
2013-03-04 20:53   ` Alexander Aring
2013-03-05 10:46     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130304204656.GD911@x61s.8.8.8.8 \
    --to=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox