From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UDLXx-0007CS-T7 for barebox@lists.infradead.org; Wed, 06 Mar 2013 21:06:52 +0000 Date: Wed, 6 Mar 2013 22:06:40 +0100 From: Sascha Hauer Message-ID: <20130306210640.GM1906@pengutronix.de> References: <20130306083849.GC4401@game.jcrosoft.org> <1362559192-11992-1-git-send-email-plagnioj@jcrosoft.com> <1362559192-11992-7-git-send-email-plagnioj@jcrosoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1362559192-11992-7-git-send-email-plagnioj@jcrosoft.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 7/9] net/console: switch to pr_xxx To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Wed, Mar 06, 2013 at 09:39:50AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > --- > net/netconsole.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/netconsole.c b/net/netconsole.c > index 7d0f3f4..8db8356 100644 > --- a/net/netconsole.c > +++ b/net/netconsole.c > @@ -185,7 +185,7 @@ static int netconsole_init(void) > > ret = console_register(cdev); > if (ret) { > - printf("netconsole: registering failed with %s\n", strerror(-ret)); > + pr_err("netconsole: registering failed with %s\n", strerror(-ret)); When you rework the printfs please add a: #define pr_fmt(fmt) "netconsole: " fmt to get a consistent layout of the pr_* messages. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox