* [PATCH] usb/gadget/Kconfig: fix menu
@ 2013-03-11 20:33 Eric Bénard
2013-03-12 17:41 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Eric Bénard @ 2013-03-11 20:33 UTC (permalink / raw)
To: barebox
by reordering the entry, USB gadget support is now a menu and the
USB gadget choices are under this menu and not directly in the
driver menu.
Signed-off-by: Eric Bénard <eric@eukrea.com>
---
drivers/usb/gadget/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 5f65cea..97a7d21 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -1,11 +1,11 @@
-menuconfig USB_GADGET
- depends on USB_HAVE_GADGET_DRIVER
- bool "USB gadget support"
-
config USB_HAVE_GADGET_DRIVER
bool
default y if ARCH_IMX || ARCH_MXS || ARCH_AT91 || ARCH_PXA
+menuconfig USB_GADGET
+ depends on USB_HAVE_GADGET_DRIVER
+ bool "USB gadget support"
+
if USB_GADGET
config USB_GADGET_DUALSPEED
--
1.7.11.7
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb/gadget/Kconfig: fix menu
2013-03-11 20:33 [PATCH] usb/gadget/Kconfig: fix menu Eric Bénard
@ 2013-03-12 17:41 ` Sascha Hauer
2013-03-12 17:51 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2013-03-12 17:41 UTC (permalink / raw)
To: Eric Bénard; +Cc: barebox
On Mon, Mar 11, 2013 at 09:33:15PM +0100, Eric Bénard wrote:
> by reordering the entry, USB gadget support is now a menu and the
> USB gadget choices are under this menu and not directly in the
> driver menu.
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
Applied, thanks
Sascha
> ---
> drivers/usb/gadget/Kconfig | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 5f65cea..97a7d21 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -1,11 +1,11 @@
> -menuconfig USB_GADGET
> - depends on USB_HAVE_GADGET_DRIVER
> - bool "USB gadget support"
> -
> config USB_HAVE_GADGET_DRIVER
> bool
> default y if ARCH_IMX || ARCH_MXS || ARCH_AT91 || ARCH_PXA
>
> +menuconfig USB_GADGET
> + depends on USB_HAVE_GADGET_DRIVER
> + bool "USB gadget support"
> +
> if USB_GADGET
>
> config USB_GADGET_DUALSPEED
> --
> 1.7.11.7
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb/gadget/Kconfig: fix menu
2013-03-12 17:41 ` Sascha Hauer
@ 2013-03-12 17:51 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-12 18:29 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-03-12 17:51 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
On 18:41 Tue 12 Mar , Sascha Hauer wrote:
> On Mon, Mar 11, 2013 at 09:33:15PM +0100, Eric Bénard wrote:
> > by reordering the entry, USB gadget support is now a menu and the
> > USB gadget choices are under this menu and not directly in the
> > driver menu.
> >
> > Signed-off-by: Eric Bénard <eric@eukrea.com>
>
> Applied, thanks
IIrc we can not do this for a Kconfig depends on USB_HAVE_GADGET_DRIVER
>
> Sascha
>
> > ---
> > drivers/usb/gadget/Kconfig | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > index 5f65cea..97a7d21 100644
> > --- a/drivers/usb/gadget/Kconfig
> > +++ b/drivers/usb/gadget/Kconfig
> > @@ -1,11 +1,11 @@
> > -menuconfig USB_GADGET
> > - depends on USB_HAVE_GADGET_DRIVER
> > - bool "USB gadget support"
> > -
> > config USB_HAVE_GADGET_DRIVER
> > bool
> > default y if ARCH_IMX || ARCH_MXS || ARCH_AT91 || ARCH_PXA
> >
> > +menuconfig USB_GADGET
> > + depends on USB_HAVE_GADGET_DRIVER
> > + bool "USB gadget support"
> > +
> > if USB_GADGET
> >
> > config USB_GADGET_DUALSPEED
> > --
> > 1.7.11.7
> >
> >
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb/gadget/Kconfig: fix menu
2013-03-12 17:51 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2013-03-12 18:29 ` Sascha Hauer
0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2013-03-12 18:29 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
On Tue, Mar 12, 2013 at 06:51:44PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 18:41 Tue 12 Mar , Sascha Hauer wrote:
> > On Mon, Mar 11, 2013 at 09:33:15PM +0100, Eric Bénard wrote:
> > > by reordering the entry, USB gadget support is now a menu and the
> > > USB gadget choices are under this menu and not directly in the
> > > driver menu.
> > >
> > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> >
> > Applied, thanks
> IIrc we can not do this for a Kconfig depends on USB_HAVE_GADGET_DRIVER
I tried it and I can't see any negative aspects.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-12 18:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-11 20:33 [PATCH] usb/gadget/Kconfig: fix menu Eric Bénard
2013-03-12 17:41 ` Sascha Hauer
2013-03-12 17:51 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-12 18:29 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox