From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ULtBg-0003pb-Uv for barebox@lists.infradead.org; Sat, 30 Mar 2013 10:39:05 +0000 Date: Sat, 30 Mar 2013 11:39:00 +0100 From: Sascha Hauer Message-ID: <20130330103900.GV1906@pengutronix.de> References: <1364395236-539-1-git-send-email-alexandre.belloni@free-electrons.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1364395236-539-1-git-send-email-alexandre.belloni@free-electrons.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2] cfa10036: Retrieve the RAM size at runtime To: Alexandre Belloni Cc: barebox@lists.infradead.org, Maxime Ripard , jimwall@q.com, brian@crystalfontz.com On Wed, Mar 27, 2013 at 03:40:36PM +0100, Alexandre Belloni wrote: > The cfa-10036 comes in two flavours, with either 128MB or 256MB of RAM > on it. > > Since it's not stored anywhere, we need to runtime detect it by > introducing the cfa10036_get_ram_size function. > > Signed-off-by: Alexandre Belloni Applied, thanks. > Cc: Maxime Ripard > --- > changes since v1: > - stripped cfa10036_get_ram_size as suggested by Sacha > - I'm not too happy about the v5_mmu_cache_flush definition and call but that > has to be done, else we are not reading the modified value, even on 128MB > boards. So your data cache works. That's good news ;) Sascha > > > arch/arm/boards/crystalfontz-cfa10036/cfa10036.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c b/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c > index 1bc20cf..a37b089 100644 > --- a/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c > +++ b/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c > @@ -90,9 +90,25 @@ static struct i2c_gpio_platform_data i2c_gpio_pdata = { > .udelay = 5, /* ~100 kHz */ > }; > > +void v5_mmu_cache_flush(void); > +long cfa10036_get_ram_size(void) > +{ > + volatile u32 *base = (void *)IMX_MEMORY_BASE; > + volatile u32 *ofs = base + SZ_128M / sizeof(u32); > + > + *base = *ofs = 0xdeadbeef; > + *ofs = 0xbaadcafe; > + > + v5_mmu_cache_flush(); > + if (*base == 0xbaadcafe) > + return SZ_128M; > + else > + return SZ_256M; > +} > + > static int cfa10036_mem_init(void) > { > - arm_add_mem_device("ram0", IMX_MEMORY_BASE, 128 * 1024 * 1024); > + arm_add_mem_device("ram0", IMX_MEMORY_BASE, cfa10036_get_ram_size()); > > return 0; > } > -- > 1.7.10.4 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox