From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands/tftp: use pr_debug for debug output
Date: Sat, 30 Mar 2013 13:46:43 +0100 [thread overview]
Message-ID: <20130330124643.GQ1568@game.jcrosoft.org> (raw)
In-Reply-To: <20130330105013.GX1906@pengutronix.de>
On 11:50 Sat 30 Mar , Sascha Hauer wrote:
> On Fri, Mar 29, 2013 at 05:32:37PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 16:08 Fri 29 Mar , Hubert Feurstein wrote:
> > > Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> > > ---
> > > commands/tftp.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/commands/tftp.c b/commands/tftp.c
> > > index 558b0ac..05d9d04 100644
> > > --- a/commands/tftp.c
> > > +++ b/commands/tftp.c
> > > @@ -76,7 +76,7 @@ static int do_tftpb(int argc, char *argv[])
> > > if (ret)
> > > goto err_rmdir;
> > >
> > > - printk("%s: %s -> %s\n", __func__, source, dest);
> > > + pr_debug("%s: %s -> %s\n", __func__, source, dest);
> > no pr_ is for device/driver not commands
>
> Saying what he should use instead is probably very helpful.
which I did
use debug
Best Regards,
J.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-03-30 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 15:08 Hubert Feurstein
2013-03-29 16:32 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-30 10:50 ` Sascha Hauer
2013-03-30 12:46 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-04-02 8:07 ` [PATCH v2] commands/tftp: use debug() " Hubert Feurstein
2013-04-03 7:11 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130330124643.GQ1568@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox