mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] omap4-fb: add driver
Date: Tue, 9 Apr 2013 09:16:08 +0200	[thread overview]
Message-ID: <20130409071608.GD1906@pengutronix.de> (raw)
In-Reply-To: <20130408071715.GS1568@game.jcrosoft.org>

On Mon, Apr 08, 2013 at 09:17:15AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 00:15 Mon 08 Apr     , Christoph Fritz wrote:
> > This patch adds omap4 display controller support.
> > 
> > +
> > +static inline void fb_write(uint32_t v, void __iomem *addr)
> > +{
> > +	__raw_writel(v, addr);
> > +}
> > +
> > +static inline uint32_t fb_read(void const __iomem *addr)
> > +{
> > +	return __raw_readl(addr);
> > +}
> what is the dif?

Maybe Christoph understands what you mean here. I don't

> > +
> > +	fbi->regs.dss   = dev_request_mem_region(dev, OMAP4_FB_RESOURCE_DSS);
> > +	fbi->regs.dispc = dev_request_mem_region(dev, OMAP4_FB_RESOURCE_DISPC);
> use named dev_request

We don't have such a function.

Could you please trim the context to sensible limits when reviewing
patches? It's hard to find your comments when you keep the complete
patch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-04-09  7:16 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04  6:42 [PATCH] " Christoph Fritz
2013-04-05  8:59 ` Sascha Hauer
2013-04-07 22:15   ` [PATCH v2] " Christoph Fritz
2013-04-08  7:17     ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-09  7:16       ` Sascha Hauer [this message]
2013-04-09 13:29         ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-11 19:01           ` Christoph Fritz
2013-06-02 21:07             ` Christoph Fritz
2013-06-12 20:45               ` [PATCH v3] " Christoph Fritz
2013-06-13 10:10                 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-13 22:40                   ` [PATCH v4] " Christoph Fritz
2013-06-14  6:29                     ` Alexander Aring
2013-06-14  7:23                       ` Jan Weitzel
2013-06-14  8:15                         ` [PATCH v5] " Christoph Fritz
2013-06-14 11:43                           ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-14 15:11                             ` [PATCH v6] " Christoph Fritz
2013-06-17  7:36                               ` Sascha Hauer
2013-06-17 16:17                                 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-18  8:47                                 ` [PATCH v7] " Christoph Fritz
2013-06-17 18:45                               ` [PATCH v6] " Alexander Aring
2013-06-17 16:18                             ` Christoph Fritz
2013-06-18  7:41                               ` Tomi Valkeinen
2013-06-18  8:09                                 ` Christoph Fritz
2013-06-18  9:59                                   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130409071608.GD1906@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox