Re: [PATCH 2/2] ARM: i.MX: Update MX51 iomux definitions

["Eric Bénard" <eric@eukrea.com>]

Hi Alexander,

Le Tue, 09 Apr 2013 12:01:51 +0400,
Alexander Shiyan <shc_work@mail.ru> a écrit :

> > > > On Sun, Apr 07, 2013 at 12:48:57PM +0400, Alexander Shiyan wrote:
> > > > > The patch updates MX51 iomux definitions from kernel.
> > > > > 
> > > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > > 
> > > > This patch effectively reverts:
> > > > 
> > > > commit 298d15571da8d1cb71e7fd87cc53cad3b2bf1d12
> > > > Author: Eric Bénard <eric@eukrea.com>
> > > > Date:   Thu Sep 6 21:39:30 2012 +0200
> > > > 
> > > >     i.MX51: unbreak FEC iomux
> > > >     
> > > >     in commit 2bdc9f57a86dff41cfc1f87b644a2e53fdcce2b6 the iomux was synced
> > > >     with the kernel but this leads to some changes in the PAD_CTRL of some
> > > >     FEC pins leading to a non working FEC on our cpuimx51 board.
> > > >     
> > > >     This patch set back the PAD_CTRL of the missing pins to the initial
> > > >     value.
> > > >     
> > > >     Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > >     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > > 
> > > > You shouldn't do this.
> > > 
> > > What about write a patch for the kernel for this?
> > 
> > By the time I applied Erics patch I considered the days of the
> > traditional iomux support in the kernel counted. From that day on
> > we have to maintain our own versions anyway.
> 
> OK. Maybe as temporary solution we can define eukrea_cpuimx51 FEC
> pins with NEW_PAD_CTRL macro? If so, I'll create a patch for this.
> This will keep iomux-mx51.h file synced.
> 
Fine for me. Do you have a problem with these pads setting so that you
need to revert the change ?

Eric

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox