From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mo5.mail-out.ovh.net ([178.32.228.5]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UPYfs-0002nf-Dz for barebox@lists.infradead.org; Tue, 09 Apr 2013 13:33:25 +0000 Received: from mail404.ha.ovh.net (gw6.ovh.net [213.251.189.206]) by mo5.mail-out.ovh.net (Postfix) with SMTP id D5527FFA779 for ; Tue, 9 Apr 2013 15:45:38 +0200 (CEST) Date: Tue, 9 Apr 2013 15:29:17 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20130409132917.GX1568@game.jcrosoft.org> References: <1365057762.3836.18.camel@mars> <20130405085917.GK1906@pengutronix.de> <1365372959.20809.6.camel@lovely> <20130408071715.GS1568@game.jcrosoft.org> <20130409071608.GD1906@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130409071608.GD1906@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2] omap4-fb: add driver To: Sascha Hauer Cc: barebox@lists.infradead.org On 09:16 Tue 09 Apr , Sascha Hauer wrote: > On Mon, Apr 08, 2013 at 09:17:15AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 00:15 Mon 08 Apr , Christoph Fritz wrote: > > > This patch adds omap4 display controller support. > > > > > > + > > > +static inline void fb_write(uint32_t v, void __iomem *addr) > > > +{ > > > + __raw_writel(v, addr); > > > +} > > > + > > > +static inline uint32_t fb_read(void const __iomem *addr) > > > +{ > > > + return __raw_readl(addr); > > > +} > > what is the dif? > > Maybe Christoph understands what you mean here. I don't those 2 inline as useless > > > > + > > > + fbi->regs.dss = dev_request_mem_region(dev, OMAP4_FB_RESOURCE_DSS); > > > + fbi->regs.dispc = dev_request_mem_region(dev, OMAP4_FB_RESOURCE_DISPC); > > use named dev_request > > We don't have such a function. yes we do dev_request_mem_region_by_name > > Could you please trim the context to sensible limits when reviewing > patches? It's hard to find your comments when you keep the complete > patch. > > Sascha > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox