From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UQ1tN-0006rQ-8z for barebox@lists.infradead.org; Wed, 10 Apr 2013 20:45:18 +0000 Received: by mail-la0-f43.google.com with SMTP id eg20so74722lab.2 for ; Wed, 10 Apr 2013 13:45:14 -0700 (PDT) Date: Thu, 11 Apr 2013 00:44:41 +0400 From: "antonynpavlov@gmail.com" Message-Id: <20130411004441.b4868f5b934c3ab4c40a107d@gmail.com> In-Reply-To: <1365585481.1951.2.camel@antimon> References: <1364883552-6563-1-git-send-email-dev@lynxeye.de> <1364883552-6563-9-git-send-email-dev@lynxeye.de> <20130405003244.c9f5c8d09a8f7c0cf2ef17ee@gmail.com> <1365418646.1877.6.camel@antimon> <20130408154610.1776c5c60c93cc81a1f237ca@gmail.com> <1365423846.1877.15.camel@antimon> <20130408170355.584a86dd71b6831077d34bf1@gmail.com> <1365585481.1951.2.camel@antimon> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v3 08/10] tegra: add generic debug UART support To: Lucas Stach Cc: barebox@lists.infradead.org On Wed, 10 Apr 2013 11:18:01 +0200 Lucas Stach wrote: > Am Montag, den 08.04.2013, 17:03 +0400 schrieb antonynpavlov@gmail.com: > > On Mon, 08 Apr 2013 14:24:06 +0200 > > Lucas Stach wrote: > > = > > > Am Montag, den 08.04.2013, 15:46 +0400 schrieb antonynpavlov@gmail.co= m: > > > > On Mon, 08 Apr 2013 12:57:26 +0200 > > > > Lucas Stach wrote: > > > > = > > > > > Hi Antony, > > > > > = > > > > > Am Freitag, den 05.04.2013, 00:32 +0400 schrieb antonynpavlov@gma= il.com: > > > > > > On Tue, 2 Apr 2013 08:19:10 +0200 > > > > > > Lucas Stach wrote: > > > > > > = > > > > > > > ODMdata tells us which UART to use for debugging purposes. Th= is is > > > > > > > agreed upon in both the upstream Linux kernel and U-Boot, so = do it the > > > > > > > same way in barebox. > > > > > > = > > > > > > This patch disables serial console on my Toshiba AC100. > > > > > > = > > > > > Hm that's unfortunate, but I already suspected that your ODMdata = might > > > > > be wrong. > > > > > What happens if you don't remove the serial init in your board? D= o you > > > > > get a duplicate serial, or just your board defined one? If it sti= ll > > > > > works for you this way, we might take this as a compromise for no= w. > > > > = > > > > IMHO, the right way is to get of_serial.c from linux and put some r= ecords = > > > > like this = > > > > uarta: serial@70006000 { > > > > compatible =3D "nvidia,tegra20-uart"; > > > > reg =3D <0x70006000 0x40>; > > > > reg-shift =3D <2>; > > > > interrupts =3D <0 36 0x04>; > > > > nvidia,dma-request-selector =3D <&apbdma 8>; > > > > clocks =3D <&tegra_car 6>; > > > > status =3D "disabled"; > > > > }; > > > > = > > > > to arch/arm/dts/tegra20.dtsi. > > > > = > > > = > > > No, this doesn't help with the decision which UART barebox should use > > > for it's output. This is a configuration option and therefore not > > > allowed to reside in the DT, so NVIDIA decided to put this information > > > into the ODMdata. Both U-Boot and the Linux kernel(for earlyconsole) = use > > > the information stored in this location. > > > = > > > You can always activate more consoles from board code or DT, but the > > > first/debug console should IMHO be handled the same way it's done in > > > Linux. > > = > > Yes, this doesn't help to select the console UART, but it provide the > > information about platform available UARTs. > > The selection of console port is board-dependent (e.g. the chip can have > > many UARTs, but the board can use only one of them), so let's move this > > selection to board configuration section. > > = > > Moreother, Toshiba AC100 is a netbook (or smartbook :), in normal mode = it > > use keyboard and LCD screen for user interaction, not UART. > > = > The generic serial patch in the series v4 now introduces a Kconfig to > override the ODMdata value. I folded in the right config into the ac100 > defconfig, so this patch should no longer break your console. > = > Also I fixed a bug that may lead to wrong ODMdata console detection, so > could you please test if it maybe also works with the automatic > detection for you now? I have just checked your patches with CONFIG_TEGRA_UART_ODMDATA=3Dy and with CONFIG_TEGRA_UART_A=3Dy Both configurations work fine! There is a very small issues (see my next messages), but IMHO, the patches = are ready for commiting. --=A0 Best regards, =A0 Antony Pavlov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox