From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UUAWZ-0007U5-Q2 for barebox@lists.infradead.org; Mon, 22 Apr 2013 06:46:52 +0000 Date: Mon, 22 Apr 2013 08:46:49 +0200 From: Sascha Hauer Message-ID: <20130422064649.GG32299@pengutronix.de> References: <1366431532-29121-1-git-send-email-shc_work@mail.ru> <1366431532-29121-4-git-send-email-shc_work@mail.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1366431532-29121-4-git-send-email-shc_work@mail.ru> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/5] GPIO: i.MX: Rewrite driver for using generic GPIO code To: Alexander Shiyan Cc: barebox@lists.infradead.org On Sat, Apr 20, 2013 at 08:18:50AM +0400, Alexander Shiyan wrote: > > Signed-off-by: Alexander Shiyan > --- > arch/arm/Kconfig | 1 - > drivers/gpio/Kconfig | 1 + > drivers/gpio/gpio-imx.c | 125 ++++++++++++------------------------------------ > 3 files changed, 31 insertions(+), 96 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index bb9b47b..5607754 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -72,7 +72,6 @@ config ARCH_HIGHBANK > > config ARCH_IMX > bool "Freescale iMX-based" > - select GENERIC_GPIO > select GPIOLIB > select COMMON_CLK > select CLKDEV_LOOKUP > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 74a4baa..5ccd35b 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -29,6 +29,7 @@ config GPIO_GENERIC_PLATFORM > > config GPIO_IMX > def_bool ARCH_IMX > + select GPIO_GENERIC I'm not convinced by this change. Indeed this makes for smaller sourcecode, but the binary gets over 1kb bigger. I think this is too much for no additional gain. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox