Re: [PATCH] clocksource: Add pointer to clocksource structure in read function

From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] clocksource: Add pointer to clocksource structure in read function
Date: Mon, 22 Apr 2013 19:03:58 +0200	[thread overview]
Message-ID: <20130422170358.GN32299@pengutronix.de> (raw)
In-Reply-To: <1366439718-31495-1-git-send-email-shc_work@mail.ru>

On Sat, Apr 20, 2013 at 10:35:18AM +0400, Alexander Shiyan wrote:
> This patch adds pointer to clocksource structure in read function.
> For avoid name collisions, clocksource names for all drivers was
> changed to be unique.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  arch/arm/mach-at91/at91rm9200_time.c  |  8 ++++----
>  arch/arm/mach-at91/at91sam926x_time.c |  8 ++++----
>  arch/arm/mach-ep93xx/clocksource.c    |  8 ++++----
>  arch/arm/mach-imx/clocksource.c       | 10 +++++-----
>  arch/arm/mach-mxs/clocksource-imx23.c | 12 +++++++-----
>  arch/arm/mach-mxs/clocksource-imx28.c |  2 +-
>  arch/arm/mach-netx/clocksource.c      |  8 ++++----
>  arch/arm/mach-omap/dmtimer0.c         |  2 +-
>  arch/arm/mach-omap/s32k_clksource.c   |  2 +-
>  arch/arm/mach-pxa/clocksource.c       |  8 ++++----
>  arch/arm/mach-samsung/s3c-timer.c     |  8 ++++----
>  arch/arm/mach-tegra/clock.c           |  8 ++++----
>  arch/arm/mach-versatile/core.c        |  2 +-
>  arch/blackfin/lib/clock.c             |  8 ++++----
>  arch/mips/lib/csrc-r4k.c              |  8 ++++----
>  arch/mips/mach-xburst/csrc-jz4750.c   |  2 +-
>  arch/nios2/lib/clock.c                |  8 ++++----
>  arch/openrisc/lib/clock.c             |  9 +++++----
>  arch/ppc/mach-mpc5xxx/time.c          |  8 ++++----
>  arch/ppc/mach-mpc85xx/time.c          | 10 +++++-----
>  arch/sandbox/board/clock.c            |  8 ++++----
>  arch/x86/mach-i386/pit_timer.c        |  8 ++++----
>  common/clock.c                        |  2 +-
>  drivers/clocksource/amba-sp804.c      |  2 +-
>  drivers/clocksource/arm_smp_twd.c     |  2 +-
>  drivers/clocksource/bcm2835.c         |  2 +-
>  drivers/clocksource/clps711x.c        |  2 +-
>  drivers/clocksource/nomadik.c         |  2 +-
>  include/clock.h                       |  2 +-
>  29 files changed, 86 insertions(+), 83 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/at91rm9200_time.c b/arch/arm/mach-at91/at91rm9200_time.c
> index 1b73a51..8f36c9f 100644
> --- a/arch/arm/mach-at91/at91rm9200_time.c
> +++ b/arch/arm/mach-at91/at91rm9200_time.c
> @@ -40,7 +40,7 @@
>   * the updates as seen by the CPU don't seem to be strictly monotonic.
>   * Waiting until we read the same value twice avoids glitching.
>   */
> -uint64_t at91rm9200_clocksource_read(void)
> +uint64_t at91rm9200_clocksource_read(struct clocksource *cs)

I also do not find this change useful. I mean, if we had a reason to
use multiple clock sources, then this would be the way to go of course,
but just doing it for the sake of more be beauttiful code, no.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox