mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Added sd driver for bcm2835 (Raspberry PI)
Date: Wed, 24 Apr 2013 11:09:56 +0200	[thread overview]
Message-ID: <20130424090956.GE13393@game.jcrosoft.org> (raw)
In-Reply-To: <20130424073521.GA32299@pengutronix.de>

On 09:35 Wed 24 Apr     , Sascha Hauer wrote:
> 
> On Tue, Apr 23, 2013 at 03:41:45PM +0200, wilhelm wrote:
> > ---
> >  arch/arm/mach-bcm2835/core.c |   1 +
> >  drivers/mci/Kconfig          |   5 +
> >  drivers/mci/Makefile         |   1 +
> >  drivers/mci/mci-bcm2835.c    | 551 +++++++++++++++++++++++++++++++++++++++++++
> >  drivers/mci/mci-bcm2835.h    | 126 ++++++++++
> >  5 files changed, 684 insertions(+)
> >  create mode 100644 drivers/mci/mci-bcm2835.c
> >  create mode 100644 drivers/mci/mci-bcm2835.h
> > 
> > diff --git a/drivers/mci/mci-bcm2835.c b/drivers/mci/mci-bcm2835.c
> > new file mode 100644
> > index 0000000..29afe0c
> > --- /dev/null
> > +++ b/drivers/mci/mci-bcm2835.c
> > @@ -0,0 +1,551 @@
> > +/*
> > + * Raspberry PI MCI driver
> > + *
> > + * Portions (e.g. read/write macros, concepts for back-to-back register write
> > + * timing workarounds) obviously extracted from the Linux kernel at:
> > + * https://github.com/raspberrypi/linux.git rpi-3.6.y
> > + *
> > + * The Linux kernel code has the following (c) and license, which is hence
> > + * propagated to here:
> > + *
> > + * Support for SDHCI device on 2835
> > + * Based on sdhci-bcm2708.c (c) 2010 Broadcom
> > + * Inspired by bcm2835_sdhci.c from git://github.com/gonzoua/u-boot-pi.git
> 
> Although it's hard to see this is a SDHCI driver. The same hardware is
> used on i.MX and I think also on Zynq.
> 
> From the i.MX SDHCI controller I know that it needs several quirks which
> will make it hard writing a common driver. At least the kernel (i.MX-)
> SDHCI driver looks nasty.
> 
> So writing a common driver may not be worth it, but I think we should
> aim for a common set of register defines. This would make it a lot
> easier to share code and to at least compare the drivers. I just sent
> out an initial series for this, maybe you could switch your driver
> to use the same defines. Later we could then search for common code.

I send the SDHCI support but the platform that use it can not be published yet
> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-04-24  9:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <wilhelm.lundgren@gmail.com>
2013-04-23 13:41 ` wilhelm
2013-04-23 14:43   ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-24  7:35   ` Sascha Hauer
2013-04-24  9:09     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-04-26  6:09 wilhelm
2013-05-08  7:24 ` Sascha Hauer
2013-05-10  6:00 wilhelm
2013-05-11 15:49 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130424090956.GE13393@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox