From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UVbBq-00020K-37 for barebox@lists.infradead.org; Fri, 26 Apr 2013 05:27:23 +0000 Date: Fri, 26 Apr 2013 07:27:16 +0200 From: Sascha Hauer Message-ID: <20130426052716.GM32299@pengutronix.de> References: <1366894187-25299-1-git-send-email-u.kleine-koenig@pengutronix.de> <20130425210037.GR15233@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130425210037.GR15233@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] of: fix how an initrd is passed to Linux To: Uwe =?iso-8859-15?Q?Kleine-K=F6nig?= Cc: barebox@lists.infradead.org On Thu, Apr 25, 2013 at 11:00:37PM +0200, Uwe Kleine-K=F6nig wrote: > On Thu, Apr 25, 2013 at 02:49:47PM +0200, Uwe Kleine-K=F6nig wrote: > > Linux expects linux,initrd-end to contain the first unused address. As > > this doesn't match the end semantic used by barebox (i.e. end contains > > the last used address) adding one is necessary. > > = > > Without this change Linux fails for me to correctly extract a gzipped > > cpio archive provided as initrd. > > = > > Signed-off-by: Uwe Kleine-K=F6nig > > --- > > drivers/of/base.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > = > > diff --git a/drivers/of/base.c b/drivers/of/base.c > > index d22031f..6cb5521 100644 > > --- a/drivers/of/base.c > > +++ b/drivers/of/base.c > > @@ -1078,6 +1078,10 @@ int of_device_is_stdout_path(struct device_d *de= v) > > * > > * Add initrd properties to the devicetree, or, if end is 0, > > * delete them. > > + * > > + * Note that Linux interprets end differently than Barebox. For Linux = end points > > + * to the first address after the memory occupied by the image while b= arebox > > + * lets end pointing the the last occupied byte. > The first "the" in the line above should be a "to". Sascha: Assuming you > are happy with the patch: Can you fix this up while committing? Applied and fixed. Thanks Sascha -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox