From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UVpen-0005Gv-Ve for barebox@lists.infradead.org; Fri, 26 Apr 2013 20:54:14 +0000 Date: Fri, 26 Apr 2013 22:54:12 +0200 From: Sascha Hauer Message-ID: <20130426205412.GX32299@pengutronix.de> References: <1366994474-21325-1-git-send-email-shc_work@mail.ru> <1366994474-21325-5-git-send-email-shc_work@mail.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1366994474-21325-5-git-send-email-shc_work@mail.ru> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 5/9] MCI: imx-esdhc: Fix possible null pointer dereference To: Alexander Shiyan Cc: barebox@lists.infradead.org On Fri, Apr 26, 2013 at 08:41:10PM +0400, Alexander Shiyan wrote: > > Signed-off-by: Alexander Shiyan > --- > drivers/mci/imx-esdhc.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/mci/imx-esdhc.c b/drivers/mci/imx-esdhc.c > index 8c2695c..8194b4d 100644 > --- a/drivers/mci/imx-esdhc.c > +++ b/drivers/mci/imx-esdhc.c > @@ -450,10 +450,15 @@ static int esdhc_card_present(struct mci_host *mci) > static int esdhc_init(struct mci_host *mci, struct device_d *dev) > { > struct fsl_esdhc_host *host = to_fsl_esdhc(mci); > - struct fsl_esdhc __iomem *regs = host->regs; > + struct fsl_esdhc __iomem *regs; > int timeout = 1000; > int ret = 0; > > + if (!host) > + return -EIO; How should that happen? The mci core should not call this callback with a NULL pointer, and if it does, there is a bug in the mci core. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox