mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 8/9] Serial: mpc5xxx: Fix setup mode at port initialization
Date: Tue, 30 Apr 2013 09:39:42 +0200	[thread overview]
Message-ID: <20130430073942.GL20989@pengutronix.de> (raw)
In-Reply-To: <1366994474-21325-8-git-send-email-shc_work@mail.ru>

On Fri, Apr 26, 2013 at 08:41:13PM +0400, Alexander Shiyan wrote:
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  drivers/serial/serial_mpc5xxx.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/serial/serial_mpc5xxx.c b/drivers/serial/serial_mpc5xxx.c
> index 532eea3..ed77807 100644
> --- a/drivers/serial/serial_mpc5xxx.c
> +++ b/drivers/serial/serial_mpc5xxx.c
> @@ -82,12 +82,10 @@ static int __mpc5xxx_serial_init(struct mpc5xxx_psc *psc)
>  	psc->sicr = 0;
>  
>  	/* configure parity, bit length and so on */
> +	psc->mode = PSC_MODE_8_BITS | PSC_MODE_PARNONE | PSC_MODE_ONE_STOP;
>  #if defined(CONFIG_MGT5100)
> -	psc->mode = PSC_MODE_ERR | PSC_MODE_8_BITS | PSC_MODE_PARNONE;
> -#elif defined(CONFIG_MPC5200)
> -	psc->mode = PSC_MODE_8_BITS | PSC_MODE_PARNONE;
> +	psc->mode |= PSC_MODE_ERR;
>  #endif
> -	psc->mode = PSC_MODE_ONE_STOP;

Without this patch psc->mode gets configured differently on mpc5200 and
on mgt5100, then afterwards overwritten on both. This surely was not
intended, but nevertheless the driver works as expected. Was this patch
tested?

BTW CONFIG_MGT5100 could be removed, we do not have support for this
SoC.

Meanwhile I applied most patches of this series.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-04-30  7:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 16:41 [PATCH 1/9] console: Fix possible null pointer dereference Alexander Shiyan
2013-04-26 16:41 ` [PATCH 2/9] ARM: at91 gpio: " Alexander Shiyan
2013-04-26 16:59   ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-26 20:48     ` Sascha Hauer
2013-04-26 16:41 ` [PATCH 3/9] ARM: at91 smc: Fix possible uninitialized variable Alexander Shiyan
2013-04-26 16:59   ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-26 17:09     ` Re[2]: " Alexander Shiyan
2013-04-26 20:49       ` Sascha Hauer
2013-04-26 16:41 ` [PATCH 4/9] MCI: atmel: Fix possible null pointer dereference Alexander Shiyan
2013-04-26 16:41 ` [PATCH 5/9] MCI: imx-esdhc: " Alexander Shiyan
2013-04-26 20:54   ` Sascha Hauer
2013-04-27  4:45     ` Re[2]: " Alexander Shiyan
2013-04-26 16:41 ` [PATCH 6/9] MCI: imx: " Alexander Shiyan
2013-04-26 16:41 ` [PATCH 7/9] NAND: imx: Fix memory leak Alexander Shiyan
2013-04-26 16:41 ` [PATCH 8/9] Serial: mpc5xxx: Fix setup mode at port initialization Alexander Shiyan
2013-04-30  7:39   ` Sascha Hauer [this message]
2013-04-30  7:46     ` Re[2]: " Alexander Shiyan
2013-04-26 16:41 ` [PATCH 9/9] MCI: imx-esdhc: Remove now unneeded check Alexander Shiyan
2013-04-26 20:57   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130430073942.GL20989@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox