From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH RFC 1/2] bootm: Simplify initrd address handling
Date: Fri, 3 May 2013 06:24:26 +0200 [thread overview]
Message-ID: <20130503042426.GS32299@pengutronix.de> (raw)
In-Reply-To: <1367485632-10725-2-git-send-email-u.kleine-koenig@pengutronix.de>
On Thu, May 02, 2013 at 11:07:11AM +0200, Uwe Kleine-König wrote:
> data.initrd_address = UIMAGE_SOME_ADDRESS;
> ...
> if (-L was given to bootm)
> data.initrd_address = address_provided_to_-L;
> ...
> if (initrd is provided as uInitrd && data.initrd_address == UIMAGE_SOME_ADDRESS)
> data.initrd_address = load_address_from_uInitrd;
> ...
> if (data.initrd_address == UIMAGE_SOME_ADDRESS)
> data.initrd_address = UIMAGE_INVALID_ADDRESS;
>
> can be simplified to:
>
> data.initrd_address = UIMAGE_INVALID_ADDRESS;
> ...
> if (-L was given to bootm)
> data.initrd_address = address_provided_to_-L;
> ...
> if (initrd is provided as uInitrd && data.initrd_address == UIMAGE_INVALID_ADDRESS)
> data.initrd_address = load_address_from_uInitrd;
> ...
>
> The only change introduced by this simplification is for cases where the
> user passes -L UIMAGE_SOME_ADDRESS or -L UIMAGE_INVALID_ADDRESS to
> bootm. (-L UIMAGE_SOME_ADDRESS is now used literally instead of ignored
> before. -L UIMAGE_INVALID_ADDRESS used to skip getting the
> initrd-address from the uInitrd, now the uInitrd address is honored.)
And now I remember why I did that in the first place. It was to be able
to explicitly ignore a uInitrd load address from an image. Anyway, since
we ignore this address in any case with the next patch these patches are
ok.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-05-03 4:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 9:07 [PATCH RFC 0/2] Fix uInitrd handling Uwe Kleine-König
2013-05-02 9:07 ` [PATCH RFC 1/2] bootm: Simplify initrd address handling Uwe Kleine-König
2013-05-03 4:24 ` Sascha Hauer [this message]
2013-05-02 9:07 ` [PATCH RFC 2/2] Don't honor initrd load address Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130503042426.GS32299@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox