mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Lior Amsalem <alior@marvell.com>,
	barebox@lists.infradead.org, Jason Cooper <jason@lakedaemon.net>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH 0/7] Basic support for Marvell Armada 370/XP SoC
Date: Sun, 5 May 2013 08:33:18 +0200	[thread overview]
Message-ID: <20130505063318.GX32299@pengutronix.de> (raw)
In-Reply-To: <20130504195228.4ba1cdca@skate>

Hi Thomas,

On Sat, May 04, 2013 at 07:52:28PM +0200, Thomas Petazzoni wrote:
> Dear Jason Cooper,
> 
> On Sat, 4 May 2013 13:15:30 -0400, Jason Cooper wrote:
> 
> > Great work!  Very clean series.  I only have one thought.  Prafulla
> > (u-boot kirkwood maintainer) is always asking about consolidating the
> > kwbimage.cfg files.  The three you've submitted for the first three
> > boards are almost (if not entirely) identical.  Before a whole bunch of
> > boards get added, should we make a kwbimage-common.cfg or similar?
> 
> I'm not sure I want to make the configuration language more complicated
> than it is already. It's already a pain to parse such a configuration
> file in C (I would have preferred to write the kwbimage tool in Python,
> but since all existing Barebox tools are in C, I wasn't sure a Python
> tool would have been accepted). Adding the support for includes means
> that you have to recursively handle includes, etc. I'm not sure I want
> to go down this road for files that typically have between 10 to 30
> lines.

How about using the C preprocessor for includes if they become
necessary?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2013-05-05  6:33 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-03 16:51 Thomas Petazzoni
2013-05-03 16:51 ` [PATCH 1/7] scripts: allow lines longer than 80 cols with printf() in checkpatch Thomas Petazzoni
2013-05-06  7:23   ` Sascha Hauer
2013-05-06  7:27     ` Thomas Petazzoni
2013-05-03 16:51 ` [PATCH 2/7] scripts: new kwbimage manipulation tool for Marvell SoC boot images Thomas Petazzoni
2013-05-04 19:51   ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-04 20:32     ` Jason Cooper
2013-05-05  6:40       ` Sascha Hauer
2013-05-05 11:19       ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-05 11:40         ` Willy Tarreau
2013-05-06 13:53         ` Thomas Petazzoni
2013-05-06 13:54           ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-06 14:06             ` Thomas Petazzoni
2013-05-06 14:04               ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-06 14:13                 ` Thomas Petazzoni
2013-05-06 14:14                   ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-06 14:31                     ` Willy Tarreau
2013-05-06 19:34                       ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-06 19:53                         ` Willy Tarreau
2013-05-06 20:21                           ` Thomas Petazzoni
2013-05-06 20:35                             ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-06 20:44                               ` Thomas Petazzoni
2013-05-06 20:56                                 ` Sascha Hauer
2013-05-06 21:03                                   ` Thomas Petazzoni
2013-05-07  6:31                                     ` Sascha Hauer
2013-05-07  9:33                                     ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-07  9:46                                       ` Willy Tarreau
2013-05-07  9:47                                       ` Sascha Hauer
2013-05-07  9:57                                         ` Thomas Petazzoni
2013-05-06 20:48                               ` Sascha Hauer
2013-05-06 14:21                 ` Jason Cooper
2013-05-06 19:39                   ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-07  6:44         ` Sascha Hauer
2013-05-06 19:41     ` Sascha Hauer
2013-05-06 19:16   ` Sascha Hauer
2013-05-06 20:22     ` Thomas Petazzoni
2013-05-07 23:30   ` Gregory CLEMENT
2013-05-03 16:51 ` [PATCH 3/7] scripts: add kwboot tool Thomas Petazzoni
2013-05-03 16:51 ` [PATCH 4/7] arm: initial support for Marvell Armada 370/XP SoCs Thomas Petazzoni
2013-05-06 14:09   ` Thomas Petazzoni
2013-05-06 14:07     ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-06 14:30     ` Sascha Hauer
2013-05-06 14:34       ` Thomas Petazzoni
2013-05-06 14:46         ` Sascha Hauer
2013-05-06 14:48           ` Thomas Petazzoni
2013-05-03 16:51 ` [PATCH 5/7] arm: add basic support for Armada XP OpenBlocks AX3 platform Thomas Petazzoni
2013-05-05  6:59   ` Sascha Hauer
2013-05-03 16:51 ` [PATCH 6/7] arm: add basic support for the Armada 370 Mirabox platform Thomas Petazzoni
2013-05-03 16:51 ` [PATCH 7/7] arm: add basic support for the Armada XP GP platform Thomas Petazzoni
2013-05-04 17:15 ` [PATCH 0/7] Basic support for Marvell Armada 370/XP SoC Jason Cooper
2013-05-04 17:23   ` Re[2]: " Alexander Shiyan
2013-05-04 17:49     ` Thomas Petazzoni
2013-05-04 17:52       ` Re[2]: " Alexander Shiyan
2013-05-04 17:52   ` Thomas Petazzoni
2013-05-04 18:34     ` Jason Cooper
2013-05-05  6:33     ` Sascha Hauer [this message]
2013-05-06 13:54       ` Thomas Petazzoni
2013-05-06 19:28 ` Sascha Hauer
2013-05-06 20:32   ` Thomas Petazzoni
2013-05-07 23:28 ` Gregory CLEMENT
2013-05-07 23:46   ` Gregory CLEMENT
2013-05-08 10:46   ` Thomas Petazzoni
2013-05-08 21:02     ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130505063318.GX32299@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=alior@marvell.com \
    --cc=barebox@lists.infradead.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox