Re: [PATCH 2/7] scripts: new kwbimage manipulation tool for Marvell SoC boot images

[Willy Tarreau <w@1wt.eu>]

On Sun, May 05, 2013 at 01:19:27PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 16:32 Sat 04 May     , Jason Cooper wrote:
> > On Sat, May 04, 2013 at 09:51:25PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > On 18:51 Fri 03 May     , Thomas Petazzoni wrote:
> > > > The Marvell EBU SoCs (Kirkwood, Armada 370, Armada XP) have a BootROM
> > > > that understand a specific image format, composed of a main header,
> > > > several extension headers and a paylod. This image can be booted from
> > > > NAND, SPI, SATA, UART, NOR, etc.
> > > > 
> > > > This patch adds a tool that allows to extract the components and
> > > > configuration of existing images, and to create new images.
> > > 
> > > I don't like this
> > 
> > Why?
> to geneate a simple header do it in C not with a tools
> > 
> > > please as on imx in barebox directly
> > 
> > what?  Could you please explain?
> 
> read the imx code we do it in C and place it at the begenning of the binary so
> no need such tools and we can use linker scirpt and CONFIG_xx
> 
> Stop to think u-boot here

I don't see why you're talking about u-boot here, the tool is needed to
extract a binary payload from existing images in order to reuse it with
new images. Now whether you'd prefer have some C code contain a dump of
this 48kB payload or have a tool to build the final image will not change
the fact that such an extraction tool is needed anyway.

Willy


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox