From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 13.mo5.mail-out.ovh.net ([87.98.182.191] helo=mo5.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UbB88-0003Pg-Df for barebox@lists.infradead.org; Sat, 11 May 2013 14:50:37 +0000 Received: from mail639.ha.ovh.net (b6.ovh.net [213.186.33.56]) by mo5.mail-out.ovh.net (Postfix) with SMTP id 81410FF96C1 for ; Sat, 11 May 2013 16:42:36 +0200 (CEST) Date: Sat, 11 May 2013 16:38:17 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20130511143817.GF19265@game.jcrosoft.org> References: <1368194658-2961-1-git-send-email-shc_work@mail.ru> <1368269656.44400096@f345.mail.ru> <20130511113155.GE19265@game.jcrosoft.org> <1368273956.326411741@f386.i.mail.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1368273956.326411741@f386.i.mail.ru> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] GPIO: Add gpio_to_desc helper To: Alexander Shiyan Cc: barebox@lists.infradead.org On 16:05 Sat 11 May , Alexander Shiyan wrote: > > > > On 18:04 Fri 10 May , Alexander Shiyan wrote: > > > > > Patch adds gpio_to_desc helper for validate GPIO. > > > > > A bit optimization is performed (about -250 bytes on ARM). > > > > > > > > > > Signed-off-by: Alexander Shiyan > > > > > --- > > > > > drivers/gpio/gpiolib.c | 97 ++++++++++++++++++++++++++------------------------ > > > > > 1 file changed, 51 insertions(+), 46 deletions(-) > > > > > > > > > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > > > > > index 6398268..d7aa094 100644 > > > > > --- a/drivers/gpio/gpiolib.c > > > > > +++ b/drivers/gpio/gpiolib.c > > > > > @@ -32,20 +32,30 @@ static int gpio_ensure_requested(struct gpio_info *gi, int gpio) > > > > > return gpio_request(gpio, "gpio"); > > > > > } > > > > > > > > > > +static struct gpio_info *gpio_to_desc(unsigned gpio) > > > > > +{ > > > > > + if (!gpio_is_valid(gpio)) > > > > put the WARN too as we need to known a gpio_xxx is used on a non valid gpio > > > > > > Original bb code does not contain any warnings here. So if it really > > > necessary it can be added later. > > > > put it as we keep the code inline with the kernel a key point for sync > > And this warning avoid my second patch to remove checks when we are > call gpio_free/set/get etc... with non existent (optional) gpios. yes as this patch break the compatibility with the kernel sorry NACK on it > I strongly do not want to add it. if you can gpio_xxx with an invalid gpio it's wrong and as we keep the same API as in linux we need to WARN as you DO need to check the gpio is valid before calling the gpio lib we keep api in sync to simplify maintainance between barebox and the kernel Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox