From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <dev@lynxeye.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] arm: properly init alignment trap bit
Date: Sat, 11 May 2013 17:46:26 +0200 [thread overview]
Message-ID: <20130511154626.GS32299@pengutronix.de> (raw)
In-Reply-To: <1368210589-21434-1-git-send-email-dev@lynxeye.de>
On Fri, May 10, 2013 at 08:29:49PM +0200, Lucas Stach wrote:
> On ARMv7 the intention is to disable the alignment trap to be able to
> use hardware assisted unaligned load/stores. Fix the init to do the
> right thing.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
Applied, thanks.
Although this fixes a bug I applied it to -next for now since this was
around for longer and everything appeared to work.
(Though I really wonder how this could ever work)
Sascha
> ---
> arch/arm/include/asm/barebox-arm-head.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/barebox-arm-head.h b/arch/arm/include/asm/barebox-arm-head.h
> index 9385415..9a8cc87 100644
> --- a/arch/arm/include/asm/barebox-arm-head.h
> +++ b/arch/arm/include/asm/barebox-arm-head.h
> @@ -22,7 +22,7 @@ static inline void arm_cpu_lowlevel_init(void)
>
> #if __LINUX_ARM_ARCH__ >= 6
> r |= CR_U;
> - r &= CR_A;
> + r &= ~CR_A;
> #else
> r |= CR_A;
> #endif
> --
> 1.8.1.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-05-11 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 18:29 Lucas Stach
2013-05-11 15:46 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130511154626.GS32299@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dev@lynxeye.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox