mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] arm: properly init alignment trap bit
@ 2013-05-10 18:29 Lucas Stach
  2013-05-11 15:46 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2013-05-10 18:29 UTC (permalink / raw)
  To: barebox

On ARMv7 the intention is to disable the alignment trap to be able to
use hardware assisted unaligned load/stores. Fix the init to do the
right thing.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 arch/arm/include/asm/barebox-arm-head.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/include/asm/barebox-arm-head.h b/arch/arm/include/asm/barebox-arm-head.h
index 9385415..9a8cc87 100644
--- a/arch/arm/include/asm/barebox-arm-head.h
+++ b/arch/arm/include/asm/barebox-arm-head.h
@@ -22,7 +22,7 @@ static inline void arm_cpu_lowlevel_init(void)
 
 #if __LINUX_ARM_ARCH__ >= 6
 	r |= CR_U;
-	r &= CR_A;
+	r &= ~CR_A;
 #else
 	r |= CR_A;
 #endif
-- 
1.8.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm: properly init alignment trap bit
  2013-05-10 18:29 [PATCH] arm: properly init alignment trap bit Lucas Stach
@ 2013-05-11 15:46 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2013-05-11 15:46 UTC (permalink / raw)
  To: Lucas Stach; +Cc: barebox

On Fri, May 10, 2013 at 08:29:49PM +0200, Lucas Stach wrote:
> On ARMv7 the intention is to disable the alignment trap to be able to
> use hardware assisted unaligned load/stores. Fix the init to do the
> right thing.
> 
> Signed-off-by: Lucas Stach <dev@lynxeye.de>

Applied, thanks.

Although this fixes a bug I applied it to -next for now since this was
around for longer and everything appeared to work.
(Though I really wonder how this could ever work)

Sascha

> ---
>  arch/arm/include/asm/barebox-arm-head.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/barebox-arm-head.h b/arch/arm/include/asm/barebox-arm-head.h
> index 9385415..9a8cc87 100644
> --- a/arch/arm/include/asm/barebox-arm-head.h
> +++ b/arch/arm/include/asm/barebox-arm-head.h
> @@ -22,7 +22,7 @@ static inline void arm_cpu_lowlevel_init(void)
>  
>  #if __LINUX_ARM_ARCH__ >= 6
>  	r |= CR_U;
> -	r &= CR_A;
> +	r &= ~CR_A;
>  #else
>  	r |= CR_A;
>  #endif
> -- 
> 1.8.1.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-11 15:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-10 18:29 [PATCH] arm: properly init alignment trap bit Lucas Stach
2013-05-11 15:46 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox