mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 08/10] ARM: i.MX51 babbage: provide MAC adress in devicetree
Date: Tue, 21 May 2013 19:53:13 +0200	[thread overview]
Message-ID: <20130521175313.GS32299@pengutronix.de> (raw)
In-Reply-To: <1369149765.377662790@f99.mail.ru>

On Tue, May 21, 2013 at 07:22:45PM +0400, Alexander Shiyan wrote:
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> >  arch/arm/dts/imx51-babbage.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/arm/dts/imx51-babbage.dts b/arch/arm/dts/imx51-babbage.dts
> > index 9630b61..4c43312 100644
> > --- a/arch/arm/dts/imx51-babbage.dts
> > +++ b/arch/arm/dts/imx51-babbage.dts
> > @@ -216,6 +216,10 @@
> >  	status = "okay";
> >  };
> >  
> > +&iim {
> > +	barebox,provide-mac-address = <&fec 1 9>;
> > +};
> 
> Fixme, is this entry compatible with kernel devicetree?
> If not, should it be stripped from dt passed to kernel?

It's compatible in the sense that the Kernel does not use this
property (it does not even use the iim node).

I see no reason why it should hurt the Kernel when there are some
barebox specific properties in the devicetree, at least not when they
are explicitly specified as barebox specific.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-05-21 17:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21  9:57 [PATCH] move the first i.MX board over to devicetree Sascha Hauer
2013-05-21  9:57 ` [PATCH 01/10] ARM: i.MX: remove unused .mac_addr_base in iim Sascha Hauer
2013-05-21  9:57 ` [PATCH 02/10] ARM: i.MX: iim: Add devicetree probe support Sascha Hauer
2013-05-21  9:57 ` [PATCH 03/10] ARM: i.MX51: Add devicetree files Sascha Hauer
2013-05-21  9:57 ` [PATCH 04/10] ARM: i.MX51: Add IIM devicetree node Sascha Hauer
2013-05-21  9:57 ` [PATCH 05/10] ARM: i.MX51: Fixup fec pads in dts Sascha Hauer
2013-05-21  9:57 ` [PATCH 06/10] ARM: i.MX51: skip devices register when devicetree is present Sascha Hauer
2013-05-21  9:57 ` [PATCH 07/10] ARM: i.MX51 babbage: Add spi-cs-high property to pmic Sascha Hauer
2013-05-21  9:57 ` [PATCH 08/10] ARM: i.MX51 babbage: provide MAC adress in devicetree Sascha Hauer
2013-05-21 15:22   ` Alexander Shiyan
2013-05-21 17:53     ` Sascha Hauer [this message]
2013-05-21  9:57 ` [PATCH 09/10] ARM: i.MX51 babbage: Add phy reset gpio to dts Sascha Hauer
2013-05-21  9:57 ` [PATCH 10/10] ARM: i.MX51 babbage: switch to devicetree Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130521175313.GS32299@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox