From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC, PATCH v2 2/3] net: add ar231x-eth support
Date: Fri, 24 May 2013 11:14:48 +0200 [thread overview]
Message-ID: <20130524091448.GD27130@game.jcrosoft.org> (raw)
In-Reply-To: <20130524070916.GX32299@pengutronix.de>
On 09:09 Fri 24 May , Sascha Hauer wrote:
> On Wed, May 22, 2013 at 09:49:48AM +0200, Oleksij Rempel wrote:
> > This driver should work with some Atheros WiSoCs:
> > - ar2312, ar2313
> > - ar2315, ar2316 ...
> >
> > Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> > ---
> > drivers/net/Kconfig | 7 +
> > drivers/net/Makefile | 1 +
> > drivers/net/ar231x.c | 429 +++++++++++++++++++++++++++++++++++++++++++++++++++
> > drivers/net/ar231x.h | 219 ++++++++++++++++++++++++++
> > 4 files changed, 656 insertions(+)
> > create mode 100644 drivers/net/ar231x.c
> > create mode 100644 drivers/net/ar231x.h
> >
> > +
> > + /* FIXME: priv->{t,r}x_ring are virtual addresses,
> > + * use virt-to-phys convertion */
>
> We use 1:1 mappings, so I think this comment should be removed.
on mips it's not the case
>
> > +
> > +static void ar231x_allocate_dma_descriptors(struct eth_device *edev)
> > +{
> > + struct ar231x_eth_priv *priv = edev->priv;
> > + u16 ar231x_descr_size = sizeof(struct ar231x_descr);
> > + u16 i;
> > +
> > + priv->tx_ring = xmalloc(ar231x_descr_size);
>
> What alignment do you need here? This may or may not be safe.
dma_alloc too
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-05-24 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 7:49 [RFC, PATCH v2 0/3] work on atheros ar2313 Oleksij Rempel
2013-05-22 7:49 ` [RFC, PATCH v2 1/3] MIPS: add Atheros ar531x family support Oleksij Rempel
2013-05-23 13:35 ` Sascha Hauer
2013-05-23 13:43 ` Oleksij Rempel
2013-05-22 7:49 ` [RFC, PATCH v2 2/3] net: add ar231x-eth support Oleksij Rempel
2013-05-24 7:09 ` Sascha Hauer
2013-05-24 9:14 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-05-25 15:57 ` Oleksij Rempel
2013-05-28 6:57 ` Sascha Hauer
2013-05-22 7:49 ` [RFC, PATCH v2 3/3] MIPS: ar231x: add netgear-wg102 Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130524091448.GD27130@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox