mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Juergen Beisert <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 1/6] mci: print current clock in info
Date: Fri, 31 May 2013 09:33:09 +0200	[thread overview]
Message-ID: <201305310933.09632.jbe@pengutronix.de> (raw)
In-Reply-To: <1369984443-8790-1-git-send-email-s.hauer@pengutronix.de>

Sascha Hauer wrote:
> When printing the cards information the actual clock is much
> more interesting than what the card could support.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  drivers/mci/mci-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index 416168f..283df2f 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -1395,7 +1395,7 @@ static void mci_info(struct device_d *dev)
>  		mci->cid[2], mci->cid[3]);
>  	printf("   CSD: %08X-%08X-%08X-%08X\n", mci->csd[0], mci->csd[1],
>  		mci->csd[2], mci->csd[3]);
> -	printf("  Max. transfer speed: %u Hz\n", mci->tran_speed);
> +	printf("  clock: %u Hz\n", mci->host->clock);
>  	printf("  Manufacturer ID: %02X\n", extract_mid(mci));
>  	printf("  OEM/Application ID: %04X\n", extract_oid(mci));
>  	printf("  Product name: '%c%c%c%c%c'\n", mci->cid[0] & 0xff,

But here you ask for the card itself. If you want to know the currently *used* 
transfer speed you must ask the interface.

Please keep this information available, as it helps others to get some 
information about the used card and might help to debug.

jbe
-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2013-05-31  7:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-31  7:13 Sascha Hauer
2013-05-31  7:13 ` [PATCH 2/6] mci: do not limit clock to card capabilities Sascha Hauer
2013-05-31  7:30   ` Juergen Beisert
2013-05-31  7:14 ` [PATCH 3/6] mci: rename trans_speed field to csd_max_dtr Sascha Hauer
2013-05-31  7:35   ` Juergen Beisert
2013-05-31  7:14 ` [PATCH 4/6] mci: Use csd_max_dtr when appropriate Sascha Hauer
2013-05-31  7:37   ` Juergen Beisert
2013-05-31  7:14 ` [PATCH 5/6] mci: Add devicetree helper function Sascha Hauer
2013-05-31  7:14 ` [PATCH 6/6] mci: i.MX esdhc: get additional parameters from devicetree Sascha Hauer
2013-05-31  7:33 ` Juergen Beisert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201305310933.09632.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox