From: "antonynpavlov@gmail.com" <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/6] MIPS: rzx50: pbl: use debug_ll
Date: Mon, 3 Jun 2013 11:46:25 +0400 [thread overview]
Message-ID: <20130603114625.775db202a34aabcd581ff461@gmail.com> (raw)
In-Reply-To: <20130603073132.GB26150@pengutronix.de>
On Mon, 3 Jun 2013 09:31:32 +0200
Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Sat, Jun 01, 2013 at 11:52:46AM +0400, Antony Pavlov wrote:
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> > arch/mips/boards/rzx50/include/board/board_pbl_start.h | 6 ++++++
> > arch/mips/mach-xburst/include/mach/debug_ll_jz4750d.h | 4 ++++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/arch/mips/boards/rzx50/include/board/board_pbl_start.h b/arch/mips/boards/rzx50/include/board/board_pbl_start.h
> > index cba3e7f..f71641a 100644
> > --- a/arch/mips/boards/rzx50/include/board/board_pbl_start.h
> > +++ b/arch/mips/boards/rzx50/include/board/board_pbl_start.h
> > @@ -18,6 +18,7 @@
> > */
> >
> > #include <asm/pbl_macros.h>
> > +#include <mach/debug_ll.h>
> >
> > .macro board_pbl_start
> > .set push
> > @@ -28,6 +29,11 @@
> > /* CPU/SoC specific setup ... */
> > /* ... absent */
> >
> > + debug_ll_ns16550_init
> > +
> > + debug_ll_ns16550_outc '.'
> > + debug_ll_ns16550_outnl
> > +
> > copy_to_link_location pbl_start
>
> I had to drop this series beginning from this patch as it breaks
> bisectibility. There seem to be some C stuff leaking in to the
> assembler.
Yes, I have moved the similar C and asm stuff to one place.
> I tried to fix this myself but I wasn't really sure what to
> to. Could you update this based on current master?
Hmm, I used the 'next' branch as the base for this patches.
I'll update the patches in a few hours.
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-06-03 7:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 7:52 [PATCH 0/6] MIPS: rework ns16550 debug_ll Antony Pavlov
2013-06-01 7:52 ` [PATCH 1/6] MIPS: XBurst: use mach-specific debug_ll setup Antony Pavlov
2013-06-01 7:52 ` [PATCH 2/6] MIPS: pbl: add low-level debug asm macros for ns16550 Antony Pavlov
2013-06-01 7:52 ` [PATCH 3/6] MIPS: rzx50: pbl: use debug_ll Antony Pavlov
2013-06-03 7:31 ` Sascha Hauer
2013-06-03 7:46 ` antonynpavlov [this message]
2013-06-01 7:52 ` [PATCH 4/6] MIPS: rzx50_defconfig: use UART1 for low-level debug Antony Pavlov
2013-06-01 7:52 ` [PATCH 5/6] MIPS: malta: adapt for new debug_ll Antony Pavlov
2013-06-01 7:52 ` [PATCH 6/6] MIPS: unificate ns16550 debug_ll support code Antony Pavlov
2013-06-01 8:07 ` antonynpavlov
2013-06-02 9:25 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130603114625.775db202a34aabcd581ff461@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox