mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH/RFC 0/5] Another try for a new memtest implementation
Date: Wed, 5 Jun 2013 23:15:35 +0200	[thread overview]
Message-ID: <20130605211535.GX32299@pengutronix.de> (raw)
In-Reply-To: <1370301232-12962-1-git-send-email-alex.aring@gmail.com>

Hi Alex,

On Tue, Jun 04, 2013 at 01:13:47AM +0200, Alexander Aring wrote:
> Hi,
> 
> this is a new try to get a new memtest implementation into barebox.
> 
> I removed the ADDRESS_IN_REGIONS macro, which was a very ugly solution.

Indeed, much nicer now.

> The new memtest command used a list and save all unused sdram_regions
> of each bank. Then running the mem_test routine on these regions.
> After that the memtest command will release the requested sdram_regions.
> 
> I removed the start and stop command arguments to make the implementation
> easier/understandable and it's not necessary anyway.

Specifying a region would be nice, but not really necessary.

> 
> Maybe it's better to remove the silent ALIGN and ALIGN_DOWN from the start
> and end address in the common mem_test routine, because addresses are already
> align.
> It is difficult to explain because a end address has the form of 0xXXXXffff
> and a ALIGN_DOWN on it with a mask of 3 we have a calculated end address of
> 0xXXXXfffA which is wrong. (0xXXXXffff - 4) - 1...
> 
> Another question is:
> Can someone test it with more than one bank, please? :-)

I gave it a test on a karo tx25 board which has two memory banks. It
works just like expected :)

Overall this looks really good now. I just applied it to -next.

Thanks
 Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2013-06-05 21:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 23:13 Alexander Aring
2013-06-03 23:13 ` [PATCH 1/5] common: fix codestyle in ALIGN macros Alexander Aring
2013-06-03 23:13 ` [PATCH 2/5] common: add ALIGN_DOWN macro Alexander Aring
2013-06-03 23:13 ` [PATCH 3/5] memtest: remove memtest command Alexander Aring
2013-06-03 23:13 ` [PATCH 4/5] common: add memtest.c with mem_test routine Alexander Aring
2013-06-03 23:13 ` [PATCH 5/5] commands: add new memtest command Alexander Aring
2013-06-05 21:15 ` Sascha Hauer [this message]
2013-06-06  7:52 ` [PATCH/RFC 0/5] Another try for a new memtest implementation antonynpavlov
2013-06-06 17:52   ` Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130605211535.GX32299@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox